Auto merge of #1305 - alexheretic:master, r=Xanewok

Fix some clippys

Author: bors

tests/client.rs

@@ -1090,35 +1090,35 @@ fn client_find_definitions() {
 
     let expected = [
         // struct Foo
-        (1, 15, vec![foo_definition.clone()]),
-        (1, 16, vec![foo_definition.clone()]),
-        (1, 17, vec![foo_definition.clone()]),
-        (1, 18, vec![foo_definition.clone()]),
+        (1, 15, vec![foo_definition]),
+        (1, 16, vec![foo_definition]),
+        (1, 17, vec![foo_definition]),
+        (1, 18, vec![foo_definition]),
         // impl Foo
-        (4, 13, vec![foo_definition.clone()]),
-        (4, 14, vec![foo_definition.clone()]),
-        (4, 15, vec![foo_definition.clone()]),
-        (4, 16, vec![foo_definition.clone()]),
+        (4, 13, vec![foo_definition]),
+        (4, 14, vec![foo_definition]),
+        (4, 15, vec![foo_definition]),
+        (4, 16, vec![foo_definition]),
         // fn new
-        (5, 15, vec![foo_new_definition.clone()]),
-        (5, 16, vec![foo_new_definition.clone()]),
-        (5, 17, vec![foo_new_definition.clone()]),
-        (5, 18, vec![foo_new_definition.clone()]),
+        (5, 15, vec![foo_new_definition]),
+        (5, 16, vec![foo_new_definition]),
+        (5, 17, vec![foo_new_definition]),
+        (5, 18, vec![foo_new_definition]),
         // fn main
-        (9, 11, vec![main_definition.clone()]),
-        (9, 12, vec![main_definition.clone()]),
-        (9, 13, vec![main_definition.clone()]),
-        (9, 14, vec![main_definition.clone()]),
-        (9, 15, vec![main_definition.clone()]),
+        (9, 11, vec![main_definition]),
+        (9, 12, vec![main_definition]),
+        (9, 13, vec![main_definition]),
+        (9, 14, vec![main_definition]),
+        (9, 15, vec![main_definition]),
         // Foo::new()
-        (10, 12, vec![foo_definition.clone()]),
-        (10, 13, vec![foo_definition.clone()]),
-        (10, 14, vec![foo_definition.clone()]),
-        (10, 15, vec![foo_definition.clone()]),
-        (10, 17, vec![foo_new_definition.clone()]),
-        (10, 18, vec![foo_new_definition.clone()]),
-        (10, 19, vec![foo_new_definition.clone()]),
-        (10, 20, vec![foo_new_definition.clone()]),
+        (10, 12, vec![foo_definition]),
+        (10, 13, vec![foo_definition]),
+        (10, 14, vec![foo_definition]),
+        (10, 15, vec![foo_definition]),
+        (10, 17, vec![foo_new_definition]),
+        (10, 18, vec![foo_new_definition]),
+        (10, 19, vec![foo_new_definition]),
+        (10, 20, vec![foo_new_definition]),
     ];
 
     if results.len() != expected.len() {

tests/tests_old.rs

@@ -1092,23 +1092,23 @@ pub trait ConvertStringCase {
 
 struct CamelCaseConverter;
 impl ConvertStringCase for CamelCaseConverter {
-    fn convert_string_case<'a>(s: &'a str) -> String {
+    fn convert_string_case(s: &str) -> String {
         use heck::CamelCase;
         s.to_camel_case().to_string()
     }
 }
 
 struct KebabCaseConverter;
 impl ConvertStringCase for KebabCaseConverter {
-    fn convert_string_case<'a>(s: &'a str) -> String {
+    fn convert_string_case(s: &str) -> String {
         use heck::KebabCase;
         s.to_kebab_case().to_string()
     }
 }
 
 struct SnakeCaseConverter;
 impl ConvertStringCase for SnakeCaseConverter {
-    fn convert_string_case<'a>(s: &'a str) -> String {
+    fn convert_string_case(s: &str) -> String {
         use heck::SnakeCase;
         s.to_snake_case().to_string()
     }