Clean up PR according to comments in #1395

Author: jabagawee

rls-analysis/examples/print-crate-id.rs

@@ -2,7 +2,6 @@ extern crate env_logger;
 extern crate rls_analysis;
 
 use rls_analysis::{AnalysisHost, AnalysisLoader, SearchDirectory};
-use std::collections::HashMap;
 use std::env;
 use std::path::{Path, PathBuf};
 
@@ -43,7 +42,7 @@ fn main() {
         std::process::exit(1);
     }
     let loader = Loader::new(PathBuf::from(env::args().nth(1).unwrap()));
-    let crates = rls_analysis::read_analysis_from_files(&loader, HashMap::new(), &[]);
+    let crates = rls_analysis::read_analysis_from_files(&loader, Default::default(), &[]);
 
     for krate in &crates {
         println!("Crate {:?} data version {:?}", krate.id, krate.analysis.version);

rls-analysis/src/lib.rs

@@ -239,7 +239,7 @@ impl<L: AnalysisLoader> AnalysisHost<L> {
     }
 
     pub fn get_def(&self, id: Id) -> AResult<Def> {
-        self.with_analysis(|a| a.with_defs(id, std::clone::Clone::clone))
+        self.with_analysis(|a| a.with_defs(id, Clone::clone))
     }
 
     pub fn goto_def(&self, span: &Span) -> AResult<Span> {
@@ -434,7 +434,7 @@ impl<L: AnalysisLoader> AnalysisHost<L> {
 
     /// Search for a symbol name, returning a list of def_ids for that name.
     pub fn search_for_id(&self, name: &str) -> AResult<Vec<Id>> {
-        self.with_analysis(|a| Some(a.with_def_names(name, std::clone::Clone::clone)))
+        self.with_analysis(|a| Some(a.with_def_names(name, Clone::clone)))
     }
 
     pub fn symbols(&self, file_name: &Path) -> AResult<Vec<SymbolResult>> {

rls-analysis/src/raw.rs

@@ -50,9 +50,9 @@ impl Crate {
 
 /// Reads raw analysis data for non-blacklisted crates from files in directories
 /// pointed by `loader`.
-pub fn read_analysis_from_files<L: AnalysisLoader, S: std::hash::BuildHasher + Default>(
+pub fn read_analysis_from_files<L: AnalysisLoader>(
     loader: &L,
-    crate_timestamps: HashMap<PathBuf, SystemTime, S>,
+    crate_timestamps: HashMap<PathBuf, SystemTime>,
     crate_blacklist: Blacklist,
 ) -> Vec<Crate> {
     let mut result = vec![];