Skip to content

Commit 6e1bb2d

Browse files
committed
Cargo already has turned on error-format=json by default.
So get rid of text wondering about making that a step in the implementation strategy.
1 parent 4c77d94 commit 6e1bb2d

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

text/0000-cargo-report-future-incompat.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -363,10 +363,8 @@ The responsibilities of Cargo:
363363
## Implmentation strategy: Leverage JSON error-format
364364

365365
The cleanest way to implement the above division of responsbilities
366-
without perturbing *non-cargo* uses of `rustc` is probably to make two changes:
367-
368-
* Cargo should *always* use `--error-format=json` for its `rustc`
369-
invocations, and
366+
without perturbing *non-cargo* uses of `rustc` is probably to make
367+
the following change:
370368

371369
* `rustc` should treat `--error-format=json` as signal that it should
372370
emit a future-incompatibility summary report for the crate.
@@ -586,8 +584,6 @@ I have not explicitly addressed nor seriously investigated this.
586584

587585
* Is using `--error-format=json` as the way to switch `rustc` into the future-incompatibility checking mode reasonable?
588586

589-
* Is turning on `--error-format=json` by default everywhere in `cargo` reasonable?
590-
591587
# Future possibilities
592588
[future-possibilities]: #future-possibilities
593589

0 commit comments

Comments
 (0)