Skip to content

Commit 5d4d98c

Browse files
committed
Revise version-querying suggestion to suggest index query first
before discussing anything with crates.io.
1 parent 571478e commit 5d4d98c

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

text/0000-cargo-report-future-incompat.md

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -111,14 +111,20 @@ Furthermore, we want the feedback to provide guidance as to how the
111111
`unwary` maintainer can address the issue. Here are some potential
112112
forms this additional guidance could take.
113113

114-
* If cargo is not running in "offline mode", it can take the
115-
future-incompatibilty signaling as an opportunity to query
116-
`crates.io` to find out if a newer version of the upstream crate is
117-
available, and if so, suggest to the user they might upgrade to it.
114+
* cargo could respond to the future-incompatibilty signaling by querying
115+
the local index to find out if a newer version of the upstream crate is
116+
available. If a newer version is available, then it could
117+
suggest to the user they might upgrade to it.
118118
If such an upgrade could be done via `cargo update`, then the
119-
output could obviously suggest that as well. (This is just a
120-
heuristic measure, as it would not attempt to check ahead of time
121-
if the newer version actually resolves the problem in question.)
119+
output could obviously suggest that as well.
120+
121+
(This is just a heuristic measure, as it would not attempt to
122+
check ahead of time if the newer version actually resolves the
123+
problem in question.)
124+
125+
A further refinement on this idea would be to query
126+
`crates.io` itself If cargo is not running in "offline mode". But
127+
querying the index may well suffice in practice.
122128

123129
* Cargo could suggest to the `unwary` maintainer that they file a bug
124130
(or search for previously-filed bug) in the source repository for

0 commit comments

Comments
 (0)