Skip to content

Commit 4d75622

Browse files
committed
More tweaks
1 parent fbd0b59 commit 4d75622

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

text/0000-extern-impl.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -212,24 +212,24 @@ graph TB
212212

213213
Impl crates depend on each other
214214
```mermaid
215-
graph TB
215+
graph LR
216216
I1 & I2 -->|impl| D
217217
I2 --> I1
218218
```
219219
Impl crates use other crates (common)
220220
```mermaid
221-
graph TB
221+
graph LR
222222
I1 -->|impl| D
223223
I1 --> T
224224
```
225225
Impl crates implement multiple definition crates
226226
```mermaid
227-
graph TB
227+
graph LR
228228
I1 -->|impl| D0 & D1
229229
```
230230
Impl crates define types and have their own impl crates
231231
```mermaid
232-
graph TB
232+
graph LR
233233
I1 -->|impl| D0
234234
I1 -->|impl| I2
235235
I2 -->|impl| D0
@@ -262,7 +262,7 @@ feature is used must be very carefully considered.
262262
# Rationale and alternatives
263263
[rationale-and-alternatives]: #rationale-and-alternatives
264264

265-
In principle you could use features to achieve similar outcomes to the
265+
In principle you could use Cargo features to achieve similar outcomes to the
266266
motivating `DBTrait` example above - you'd define a feature for each DB
267267
implementation, and the consumer would only enable the specific implementations
268268
they want.
@@ -325,3 +325,7 @@ crates.io publication time to make sure the package doesn't have lurking
325325
problems. On the other hand there might be cases where it's desireable to allow
326326
incoherent implementations to exist; for example, two implementations of the
327327
same API with different algorithms tuned for different use-cases.
328+
329+
There are cases where the same coherence properties may be checked multiple
330+
times. Perhaps these checks could be memoized with the incremental machinery to
331+
avoid the redundancy.

0 commit comments

Comments
 (0)