Skip to content

Commit 4af121b

Browse files
committed
Address PR feedback
1 parent e9f7566 commit 4af121b

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

text/3529-cargo-path-bases.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,8 @@ If the name of a base path is specified in both the manifest and configuration,
179179
then the value in the manifest is preferred.
180180

181181
The name of a base path must use only [alphanumeric](https://doc.rust-lang.org/std/primitive.char.html#method.is_alphanumeric)
182-
characters or `-` or `_`, and cannot be empty.
182+
characters or `-` or `_`, must start with an [alphabetic](https://doc.rust-lang.org/std/primitive.char.html#method.is_alphabetic)
183+
character, and must not be empty.
183184

184185
#### Built-in base paths
185186

@@ -191,7 +192,9 @@ then this base path is defined as the path to the directory containing the root
191192
Cargo.toml of the workspace.
192193

193194
If one of these built-in base paths is also specified in the manifest or
194-
configuration, then that value is preferred over the built-in value.
195+
configuration, then that value is preferred over the built-in value. This allows
196+
Cargo to introduce additional built-in paths in the future without compatibility
197+
issues, as any existing uses will shadow Cargo's built-in name.
195198

196199
## The Manifest Format
197200

@@ -361,7 +364,7 @@ could help.
361364
[unresolved-questions]: #unresolved-questions
362365

363366
- What should the Cargo configuration table and dependency key be called? This
364-
RFC calls the configuration table `base_path` to be explicit that it is
367+
RFC calls the configuration table `base-paths` to be explicit that it is
365368
dealing with paths (as `base` would be ambiguous) but calls the key `base` to
366369
keep it concise.
367370
- Is there other reasonable behavior we could fall back to if a `base`
@@ -377,7 +380,7 @@ It seems reasonable to extend `base` to `git` dependencies, with
377380
something like:
378381

379382
```toml
380-
[base_path]
383+
[base-paths]
381384
gh = "https://github.com/jonhoo"
382385
```
383386

0 commit comments

Comments
 (0)