Skip to content

Commit 374d690

Browse files
author
Keegan McAllister
committed
Fixed an implementation bug
1 parent 6d8c00b commit 374d690

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

active/0000-pattern-macros.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ match x {
1717

1818
This is consistent with allowing macros in expressions etc. It's also a year-old [open issue](https://github.com/mozilla/rust/issues/6830).
1919

20-
I have [implemented](https://github.com/mozilla/rust/pull/14298) this feature already (with some bugs) and I'm [using it](https://github.com/kmcallister/html5/blob/937684f107090741c8e87135efc6e5476489857b/src/tree_builder/mod.rs#L111-L117) to [condense](https://github.com/kmcallister/html5/blob/937684f107090741c8e87135efc6e5476489857b/src/tree_builder/mod.rs#L261-L269) some ubiquitous patterns in the [HTML parser](https://github.com/kmcallister/html5) I'm writing. This makes the code more concise and easier to cross-reference with the spec.
20+
I have [implemented](https://github.com/mozilla/rust/pull/14298) this feature already and I'm [using it](https://github.com/kmcallister/html5/blob/937684f107090741c8e87135efc6e5476489857b/src/tree_builder/mod.rs#L111-L117) to [condense](https://github.com/kmcallister/html5/blob/937684f107090741c8e87135efc6e5476489857b/src/tree_builder/mod.rs#L261-L269) some ubiquitous patterns in the [HTML parser](https://github.com/kmcallister/html5) I'm writing. This makes the code more concise and easier to cross-reference with the spec.
2121

2222
# Drawbacks / alternatives
2323

@@ -51,4 +51,4 @@ The `my_match!` approach is also not very composable.
5151

5252
# Unresolved questions
5353

54-
I need to fix the ICE described in [the pull request](https://github.com/mozilla/rust/pull/14298). I don't expect this to have any design impact, but I can't be sure.
54+
None, as far as I know.

0 commit comments

Comments
 (0)