Skip to content

Commit 1788dd4

Browse files
committed
PR feedback
1 parent e6b5dcc commit 1788dd4

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

text/0000-conditional-compilation-checking.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,12 @@ fn tame_lion() { ... }
458458
459459
## Drawbacks
460460
461-
There are no known drawbacks to this proposal.
461+
* Adds complexity, in the form of additional command-line options.
462+
* As with all lints, correct code may be trigger lints. Developers will need to take time to
463+
examine them and see whether they are legitimate or not.
464+
* To take full advantage of this, build systems (including but not limited to Cargo) must be
465+
updated. However, for those systems that are not updated, there is no penalty or drawback,
466+
since `--check-cfg` is opt-in.
462467
463468
## Rationale and alternatives
464469

0 commit comments

Comments
 (0)