Skip to content

Commit 153d286

Browse files
committed
maybe we should employ cargo fix
1 parent 2550a0b commit 153d286

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

text/0000-unsafe-block-in-unsafe-fn.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,3 +154,11 @@ culture of thinking about this in terms of proof obligations.
154154
Should this lint be in clippy first before in becomes warn-by-default in rustc,
155155
to avoid a huge flood of warnings showing up at once? Should the lint ever
156156
become a hard error (on newer editions), or remain a warning indefinitely?
157+
158+
Should we require `cargo fix` to be able to do *something* about this warning
159+
before making it warn-by-default? `cargo fix` could, for example, wrap the body
160+
of every `unsafe fn` in one big `unsafe` block. That would not improve the
161+
amount of care that is taken for unsafety in the fixed code, but it would
162+
provide a way to the incrementally improve the big functions, and new functions
163+
written later would have the appropriate amount of care applied to them from the
164+
start.

0 commit comments

Comments
 (0)