Skip to content

Commit 09b64f1

Browse files
committed
update "MCP RFC" text to match the changes made to the template
whoops.
1 parent 192b9e5 commit 09b64f1

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

text/2904-compiler-major-change-process.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,16 +48,18 @@ is as follows:
4848
[major change]: #What-constitutes-a-major-change
4949

5050
* Open a tracking issue on the [rust-lang/compiler-team] repo using the [major change template].
51-
* Create a Zulip topic in the stream `#t-compiler/major changes`, where people will discuss the design.
51+
* A Zulip topic in the stream `#t-compiler/major changes` will automatically be created for you by a bot.
5252
* If concerns are raised, you may want to modify the proposal to address those concerns.
5353
* Alternatively, you can submit a [design meeting proposal] to have a longer, focused discussion.
5454
* To be accepted, a major change proposal needs three things:
5555
* One or more **reviewers**, who commit to reviewing the work. This can be the person making the proposal, if they intend to mentor others.
56-
* A **second**, an expert in the affected area(s) of the compiler who approves of the idea, but is not the one originating the proposal.
57-
* To be **announced at a triage meeting** and go through **final comment period** (a 1 week wait to give people time).
58-
* MCPs should not be announced if they have outstanding, unresolved concerns by compiler team members. Check with a team lead if there is any doubt.
56+
* A **second**, a member of the compiler team or a contributor who approves of the idea, but is not the one originating the proposal.
57+
* A **final comment period** (a 10 day wait to give people time to comment).
5958
* The FCP can be skipped if the change is easily reversed and/or further objections are considered unlikely. This often happens if there has been a lot of prior discussion, for example.
60-
* Once the major change is accepted, PRs can start to land.
59+
* Once the FCP completes, if there are no outstanding concerns, PRs can start to land.
60+
* If those PRs make outward-facing changes that affect stable
61+
code, then either the MCP or the PR(s) must be approved with a
62+
`rfcbot fcp merge` comment.
6163

6264
## Conditional acceptance
6365

0 commit comments

Comments
 (0)