You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: text/2904-compiler-major-change-process.md
+7-5Lines changed: 7 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -48,16 +48,18 @@ is as follows:
48
48
[major change]: #What-constitutes-a-major-change
49
49
50
50
* Open a tracking issue on the [rust-lang/compiler-team] repo using the [major change template].
51
-
* Create a Zulip topic in the stream `#t-compiler/major changes`, where people will discuss the design.
51
+
* A Zulip topic in the stream `#t-compiler/major changes` will automatically be created for you by a bot.
52
52
* If concerns are raised, you may want to modify the proposal to address those concerns.
53
53
* Alternatively, you can submit a [design meeting proposal] to have a longer, focused discussion.
54
54
* To be accepted, a major change proposal needs three things:
55
55
* One or more **reviewers**, who commit to reviewing the work. This can be the person making the proposal, if they intend to mentor others.
56
-
* A **second**, an expert in the affected area(s) of the compiler who approves of the idea, but is not the one originating the proposal.
57
-
* To be **announced at a triage meeting** and go through **final comment period** (a 1 week wait to give people time).
58
-
* MCPs should not be announced if they have outstanding, unresolved concerns by compiler team members. Check with a team lead if there is any doubt.
56
+
* A **second**, a member of the compiler team or a contributor who approves of the idea, but is not the one originating the proposal.
57
+
* A **final comment period** (a 10 day wait to give people time to comment).
59
58
* The FCP can be skipped if the change is easily reversed and/or further objections are considered unlikely. This often happens if there has been a lot of prior discussion, for example.
60
-
* Once the major change is accepted, PRs can start to land.
59
+
* Once the FCP completes, if there are no outstanding concerns, PRs can start to land.
60
+
* If those PRs make outward-facing changes that affect stable
61
+
code, then either the MCP or the PR(s) must be approved with a
0 commit comments