Skip to content

Commit dbcbc3e

Browse files
committed
Disable misbehaving targets
1 parent fd712fe commit dbcbc3e

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -175,20 +175,24 @@ jobs:
175175
matrix:
176176
target:
177177
- armv7-unknown-linux-gnueabihf
178-
- thumbv7neon-unknown-linux-gnueabihf
179-
- aarch64-unknown-linux-gnu
178+
- thumbv7neon-unknown-linux-gnueabihf # includes neon by default
179+
- aarch64-unknown-linux-gnu # includes neon by default
180180
- powerpc-unknown-linux-gnu
181-
- powerpc64-unknown-linux-gnu
182-
- powerpc64le-unknown-linux-gnu
181+
- powerpc64le-unknown-linux-gnu # includes altivec by default
183182
- riscv64gc-unknown-linux-gnu
184183
# MIPS uses a nonstandard binary representation for NaNs which makes it worth testing
184+
# non-nightly since https://github.com/rust-lang/rust/pull/113274
185185
# - mips-unknown-linux-gnu
186186
# - mips64-unknown-linux-gnuabi64
187+
# Lots of errors in QEMU and no real hardware to test on. Not clear if it's QEMU or bad codegen.
188+
# - powerpc64-unknown-linux-gnu
187189
target_feature: [default]
188190
include:
189-
- { target: powerpc-unknown-linux-gnu, target_feature: "+altivec" }
190191
- { target: powerpc64-unknown-linux-gnu, target_feature: "+vsx" }
191192
- { target: powerpc64le-unknown-linux-gnu, target_feature: "+vsx" }
193+
# Fails due to QEMU floating point errors, probably handling subnormals incorrectly.
194+
# This target is somewhat redundant, since ppc64le has altivec as well.
195+
# - { target: powerpc-unknown-linux-gnu, target_feature: "+altivec" }
192196
# We should test this, but cross currently can't run it
193197
# - { target: riscv64gc-unknown-linux-gnu, target_feature: "+v,+zvl128b" }
194198

0 commit comments

Comments
 (0)