-
Notifications
You must be signed in to change notification settings - Fork 391
Closed
Labels
A-shimsArea: This affects the external function shimsArea: This affects the external function shimsC-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancement
Description
Many of the shims @christianpoveda added recently need to read or write an OsString
to/from the interpreter memory. Instead of copying that everywhere, we should have helpers that they can all call.
Moreover, right now these functions go through UTF-8. At least when running on a Unix host, we can do better by using OsStrExt
, which gives us a raw byte buffer. We probably still need the UTF-8 code path as a fallback for cross-execution.
Metadata
Metadata
Assignees
Labels
A-shimsArea: This affects the external function shimsArea: This affects the external function shimsC-enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancementCategory: a PR with an enhancement or an issue tracking an accepted enhancement