Skip to content

Commit ebc5270

Browse files
committed
Rename some methods
1 parent 31f9540 commit ebc5270

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/bin/cargo-miri.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ fn is_target_crate(is_build_script: bool) -> bool {
112112
}
113113

114114

115-
fn read_cargo_metadata() -> (impl Iterator<Item = cargo_metadata::Target>, String) {
115+
fn list_targets() -> impl Iterator<Item = cargo_metadata::Target> {
116116
// We need to get the manifest, and then the metadata, to enumerate targets.
117117
let manifest_path =
118118
get_arg_flag_value("--manifest-path").map(|m| Path::new(&m).canonicalize().unwrap());
@@ -152,7 +152,7 @@ fn read_cargo_metadata() -> (impl Iterator<Item = cargo_metadata::Target>, Strin
152152
let package = metadata.packages.remove(package_index);
153153

154154
// Finally we got the list of targets to build
155-
(package.targets.into_iter(), metadata.workspace_root.to_string_lossy().to_string())
155+
package.targets.into_iter()
156156
}
157157

158158
/// Returns the path to the `miri` binary
@@ -486,10 +486,8 @@ fn in_cargo_miri() {
486486
return;
487487
}
488488

489-
let (targets, root_dir) = read_cargo_metadata();
490-
491489
// Now run the command.
492-
for target in targets {
490+
for target in list_targets() {
493491
let mut args = std::env::args().skip(skip);
494492
let kind = target
495493
.kind
@@ -571,7 +569,7 @@ fn inside_cargo_rustc() {
571569

572570
let rustc_args = std::env::args().skip(2); // skip `cargo rustc`
573571

574-
let in_build_script = is_build_dep(std::env::args().skip(2));
572+
let in_build_script = is_build_dep();
575573

576574
let mut args = if in_build_script {
577575
rustc_args.collect()

0 commit comments

Comments
 (0)