Skip to content

Commit e48a0f2

Browse files
authored
Rollup merge of #140874 - mejrs:rads, r=WaffleLapkin
make `rustc_attr_parsing` less dominant in the rustc crate graph It has/had a glob re-export of `rustc_attr_data_structures`, which is a crate much lower in the graph, and a lot of crates were using it *just* (or *mostly*) for that re-export, while they can rely on `rustc_attr_data_structures` directly. Previous graph: ![graph_1](https://github.com/user-attachments/assets/f4a5f13c-4222-4903-b56d-28c83511fcbd) Graph with this PR: ![graph_2](https://github.com/user-attachments/assets/1e053d9c-75cc-402b-84df-86229c98277a) The first commit keeps the re-export, and just changes the dependency if possible. The second commit is the "breaking change" which removes the re-export, and "explicitly" adds the `rustc_attr_data_structures` dependency where needed. It also switches over some src/tools/*. The second commit is actually a lot more involved than I expected. Please let me know if it's a better idea to back it out and just keep the first commit.
2 parents 455e2fd + d69c79a commit e48a0f2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ extern crate tracing;
6060
extern crate rustc_abi;
6161
extern crate rustc_apfloat;
6262
extern crate rustc_ast;
63-
extern crate rustc_attr_parsing;
63+
extern crate rustc_attr_data_structures;
6464
extern crate rustc_const_eval;
6565
extern crate rustc_data_structures;
6666
extern crate rustc_errors;

src/machine.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ use rand::rngs::StdRng;
1313
use rand::{Rng, SeedableRng};
1414
use rustc_abi::{Align, ExternAbi, Size};
1515
use rustc_apfloat::{Float, FloatConvert};
16-
use rustc_attr_parsing::InlineAttr;
16+
use rustc_attr_data_structures::InlineAttr;
1717
use rustc_data_structures::fx::{FxHashMap, FxHashSet};
1818
#[allow(unused)]
1919
use rustc_data_structures::static_assert_size;

0 commit comments

Comments
 (0)