Skip to content

Commit 9551058

Browse files
committed
Resolve clippy::op_ref
error: taken reference of right operand --> src/shims/env.rs:53:63 | 53 | true => !excluded_env_vars.iter().any(|v| v.as_str() == &name), | ^^^^^^^^^^^^^^----- | | | help: use the right value directly: `name` | = note: `-D clippy::op-ref` implied by `-D clippy::all` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref error: taken reference of right operand --> src/shims/env.rs:54:71 | 54 | false => config.forwarded_env_vars.iter().any(|v| v.as_str() == &name), | ^^^^^^^^^^^^^^----- | | | help: use the right value directly: `name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
1 parent 519755a commit 9551058

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
clippy::manual_map,
2121
clippy::needless_lifetimes,
2222
clippy::new_without_default,
23-
clippy::op_ref,
2423
clippy::redundant_closure,
2524
clippy::redundant_field_names,
2625
clippy::single_char_add_str,

src/shims/env.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ impl<'tcx> EnvVars<'tcx> {
5050
if ecx.machine.communicate() || !config.forwarded_env_vars.is_empty() {
5151
for (name, value) in env::vars_os() {
5252
let forward = match ecx.machine.communicate() {
53-
true => !excluded_env_vars.iter().any(|v| v.as_str() == &name),
54-
false => config.forwarded_env_vars.iter().any(|v| v.as_str() == &name),
53+
true => !excluded_env_vars.iter().any(|v| **v == name),
54+
false => config.forwarded_env_vars.iter().any(|v| **v == name),
5555
};
5656
if forward {
5757
let var_ptr = match target_os {

0 commit comments

Comments
 (0)