clippy

Author: Ellen Arteca

src/c_ffi_support.rs

@@ -102,27 +102,27 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
                 match prim_type {
                     // ints
                     hir::PrimTy::Int(IntTy::I8) => {
-                        let x = call::<i8>(ptr, &libffi_args.as_slice());
+                        let x = call::<i8>(ptr, libffi_args.as_slice());
                         this.write_int(x, dest)?;
                         return Ok(());
                     }
                     hir::PrimTy::Int(IntTy::I16) => {
-                        let x = call::<i16>(ptr, &libffi_args.as_slice());
+                        let x = call::<i16>(ptr, libffi_args.as_slice());
                         this.write_int(x, dest)?;
                         return Ok(());
                     }
                     hir::PrimTy::Int(IntTy::I32) => {
-                        let x = call::<i32>(ptr, &libffi_args.as_slice());
+                        let x = call::<i32>(ptr, libffi_args.as_slice());
                         this.write_int(x, dest)?;
                         return Ok(());
                     }
                     hir::PrimTy::Int(IntTy::I64) => {
-                        let x = call::<i64>(ptr, &libffi_args.as_slice());
+                        let x = call::<i64>(ptr, libffi_args.as_slice());
                         this.write_int(x, dest)?;
                         return Ok(());
                     }
                     hir::PrimTy::Int(IntTy::Isize) => {
-                        let x = call::<isize>(ptr, &libffi_args.as_slice());
+                        let x = call::<isize>(ptr, libffi_args.as_slice());
                         if isize::BITS == 64 {
                             this.write_int(x as i64, dest)?;
                         } else if usize::BITS == 32 {
@@ -134,27 +134,27 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
                     }
                     // uints
                     hir::PrimTy::Uint(UintTy::U8) => {
-                        let x = call::<u8>(ptr, &libffi_args.as_slice());
+                        let x = call::<u8>(ptr, libffi_args.as_slice());
                         this.write_int(x, dest)?;
                         return Ok(());
                     }
                     hir::PrimTy::Uint(UintTy::U16) => {
-                        let x = call::<u16>(ptr, &libffi_args.as_slice());
+                        let x = call::<u16>(ptr, libffi_args.as_slice());
                         this.write_int(x, dest)?;
                         return Ok(());
                     }
                     hir::PrimTy::Uint(UintTy::U32) => {
-                        let x = call::<u32>(ptr, &libffi_args.as_slice());
+                        let x = call::<u32>(ptr, libffi_args.as_slice());
                         this.write_int(x, dest)?;
                         return Ok(());
                     }
                     hir::PrimTy::Uint(UintTy::U64) => {
-                        let x = call::<u64>(ptr, &libffi_args.as_slice());
+                        let x = call::<u64>(ptr, libffi_args.as_slice());
                         this.write_int(x, dest)?;
                         return Ok(());
                     }
                     hir::PrimTy::Uint(UintTy::Usize) => {
-                        let x = call::<usize>(ptr, &libffi_args.as_slice());
+                        let x = call::<usize>(ptr, libffi_args.as_slice());
                         if usize::BITS == 64 {
                             this.write_int(x as u64, dest)?;
                         } else if usize::BITS == 32 {
@@ -168,7 +168,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
                 }
             }
             if matches!(external_fct_defn.output_type, hir::FnRetTy::DefaultReturn(_)) {
-                call::<()>(ptr, &libffi_args.as_slice());
+                call::<()>(ptr, libffi_args.as_slice());
                 return Ok(());
             }
             // TODO ellen! deal with all the other return types
@@ -242,7 +242,7 @@ pub struct ExternalCFuncDeclRep<'hir> {
 /// Enum of supported arguments to external C functions.
 pub enum CArg {
     /// Invalid argument (unsupported type).
-    INVALID,
+    Invalid,
     /// 8-bit signed integer.
     Int8(i8),
     /// 16-bit signed integer.

src/shims/foreign_items.rs

@@ -369,7 +369,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
 
         // First deal with any external C functions in linked .so file
         // (if any SO file is specified).
-        if let Some(_) = this.machine.external_c_so_lib.as_ref() {
+        if this.machine.external_c_so_lib.as_ref().is_some() {
             if let Some(local_id) = def_id.as_local() {
                 if let Some(extern_c_fct_rep) = ExternalCFuncDeclRep::from_hir_node(
                     &tcx.hir().get(tcx.hir().local_def_id_to_hir_id(local_id)),