clippy...

Author: RalfJung

src/lib.rs

@@ -24,6 +24,7 @@
     clippy::derive_hash_xor_eq,
     clippy::too_many_arguments,
     clippy::type_complexity,
+    clippy::single_element_loop,
     // We are not implementing queries here so it's fine
     rustc::potential_query_instability
 )]

src/shims/unix/android/dlsym.rs

@@ -13,7 +13,7 @@ impl Dlsym {
     // Returns an error for unsupported symbols, and None if this symbol
     // should become a NULL pointer (pretend it does not exist).
     pub fn from_str<'tcx>(name: &str) -> InterpResult<'tcx, Option<Dlsym>> {
-        Ok(match &*name {
+        Ok(match name {
             "signal" => Some(Dlsym::signal),
             "android_set_abort_message" => None,
             _ => throw_unsup_format!("unsupported Android dlsym: {}", name),

src/shims/unix/android/foreign_items.rs

@@ -15,9 +15,12 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
         _dest: &PlaceTy<'tcx, Provenance>,
     ) -> InterpResult<'tcx, EmulateByNameResult<'mir, 'tcx>> {
         let _this = self.eval_context_mut();
+        #[allow(clippy::match_single_binding)]
         match link_name.as_str() {
             _ => return Ok(EmulateByNameResult::NotSupported),
         }
-        //Ok(EmulateByNameResult::NeedsJumping)
+
+        #[allow(unreachable_code)]
+        Ok(EmulateByNameResult::NeedsJumping)
     }
 }