Skip to content

Commit b80609c

Browse files
committed
Update PULL_REQUEST_TEMPLATE.md (#3953)
(backport <#3953>) (cherry picked from commit 3f2d4cb)
1 parent bd30fe1 commit b80609c

File tree

1 file changed

+23
-11
lines changed

1 file changed

+23
-11
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,27 @@
1-
Thanks for considering submitting a PR!
1+
<!-- Thank you for submitting a PR!
22
3-
We have the [contribution guide](https://github.com/rust-lang/libc/blob/main/CONTRIBUTING.md). Please read it if you're new here!
3+
We have the contribution guide, please read it if you are new here!
4+
<https://github.com/rust-lang/libc/blob/main/CONTRIBUTING.md>
45
5-
Here's a checklist for things that will be checked during review or continuous integration.
6+
Please fill out the below template.
7+
-->
68

7-
- \[ ] Edit corresponding file(s) under `libc-test/semver` when you add/remove item(s), e.g. edit `linux.txt` if you add an item to `src/unix/linux_like/linux/mod.rs`
8-
- \[ ] Your PR doesn't contain any private or *unstable* values like `*LAST` or `*MAX` (see [#3131](https://github.com/rust-lang/libc/issues/3131))
9-
- \[ ] If your PR has a breaking change, please clarify it
10-
- \[ ] If your PR increments version number, it must NOT contain any other changes (otherwise a release could be delayed)
11-
- \[ ] Make sure `ci/style.sh` passes
12-
- \[ ] `cd libc-test && cargo test`
13-
- (this might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure)
9+
# Description
1410

15-
Delete this line and everything above before opening your PR.
11+
<!-- Add a short description about what this change does -->
12+
13+
# Sources
14+
15+
<!-- All API changes must have links to headers and/or documentation,
16+
preferably both -->
17+
18+
# Checklist
19+
20+
<!-- Please make sure the following has been done before submitting a PR,
21+
or mark it as a draft if you are not sure. -->
22+
23+
- [ ] Relevant tests in `libc-test/semver` have been updated
24+
- [ ] No placeholder or unstable values like `*LAST` or `*MAX` are
25+
included (see [#3131](https://github.com/rust-lang/libc/issues/3131))
26+
- [ ] Tested locally (`cd libc-test && cargo test --target mytarget`);
27+
especially relevant for platforms that may not be checked in CI

0 commit comments

Comments
 (0)