Skip to content

Commit 3f2d4cb

Browse files
authored
Update PULL_REQUEST_TEMPLATE.md (#3953)
1 parent 2053d5b commit 3f2d4cb

File tree

1 file changed

+27
-25
lines changed

1 file changed

+27
-25
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,27 @@
1-
Thanks for considering submitting a PR!
2-
3-
We have the
4-
[contribution guide](https://github.com/rust-lang/libc/blob/main/CONTRIBUTING.md).
5-
Please read it if you're new here!
6-
7-
Here is a checklist for things that will be checked during review or continuous
8-
integration:
9-
10-
- \[ ] Edit corresponding file(s) under `libc-test/semver` when you add/remove
11-
item(s), e.g. edit `linux.txt` if you add an item to
12-
`src/unix/linux_like/linux/mod.rs`
13-
- \[ ] Your PR doesn't contain any private or _unstable_ values like `*LAST` or
14-
`*MAX` (see [#3131](https://github.com/rust-lang/libc/issues/3131))
15-
- \[ ] Provide a link to relevant source (headers or documentation) if your PR
16-
adds or changes API.
17-
- \[ ] If your PR has a breaking change, please clarify it
18-
- \[ ] If your PR increments version number, it must NOT contain any other
19-
changes (otherwise a release could be delayed)
20-
- \[ ] Make sure `ci/style.sh` passes
21-
- \[ ] `cd libc-test && cargo test`
22-
- (this might fail on your env due to environment difference between your env
23-
and CI. Ignore local failures if you are not sure)
24-
25-
Delete this line and everything above before opening your PR.
1+
<!-- Thank you for submitting a PR!
2+
3+
We have the contribution guide, please read it if you are new here!
4+
<https://github.com/rust-lang/libc/blob/main/CONTRIBUTING.md>
5+
6+
Please fill out the below template.
7+
-->
8+
9+
# Description
10+
11+
<!-- Add a short description about what this change does -->
12+
13+
# Sources
14+
15+
<!-- All API changes must have links to headers and/or documentation,
16+
preferably both -->
17+
18+
# Checklist
19+
20+
<!-- Please make sure the following has been done before submitting a PR,
21+
or mark it as a draft if you are not sure. -->
22+
23+
- [ ] Relevant tests in `libc-test/semver` have been updated
24+
- [ ] No placeholder or unstable values like `*LAST` or `*MAX` are
25+
included (see [#3131](https://github.com/rust-lang/libc/issues/3131))
26+
- [ ] Tested locally (`cd libc-test && cargo test --target mytarget`);
27+
especially relevant for platforms that may not be checked in CI

0 commit comments

Comments
 (0)