Skip to content

Commit 339fe22

Browse files
committed
add fixmes for the ucontext_t shadow stack field
1 parent 886bb3f commit 339fe22

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

libc-test/build.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2098,6 +2098,7 @@ fn test_linux(target: &str) {
20982098
// FIXME: musl version using by mips build jobs 1.0.15 is ancient:
20992099
"ifmap" | "ifreq" | "ifconf" if mips32_musl => true,
21002100

2101+
// FIXME: remove once Ubuntu 20.04 LTS is released, somewhere in 2020.
21012102
// ucontext_t added a new field as of glibc 2.28; our struct definition is
21022103
// conservative and omits the field, but that means the size doesn't match for newer
21032104
// glibcs (see https://github.com/rust-lang/libc/issues/1410)

src/unix/linux_like/linux/gnu/b64/x86_64/mod.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,9 @@ s_no_extra_traits! {
285285
pub uc_mcontext: mcontext_t,
286286
pub uc_sigmask: ::sigset_t,
287287
__private: [u8; 512],
288+
// FIXME: the shadow stack field requires glibc >= 2.28.
289+
// Re-add once we drop compatibility with glibc versions older than 2.28.
290+
// __ssp: [::c_ulonglong; 4],
288291
}
289292
}
290293

0 commit comments

Comments
 (0)