address review comments

Author: pietroalbini

homu/comments.py

@@ -81,3 +81,10 @@ def render(self):
         return ":broken_heart: Test failed - [%s](%s)" % (
             self.builder_name, self.builder_url
         )
+
+
+class TimedOut(Comment):
+    params = []
+
+    def render(self):
+        return ":boom: Test timed out"

homu/main.py

@@ -367,15 +367,14 @@ def timed_out(self):
         self.save()
         self.set_status('failure')
 
-        desc = 'Test timed out'
         utils.github_create_status(
             self.get_repo(),
             self.head_sha,
             'failure',
             '',
-            desc,
+            'Test timed out',
             context='homu')
-        self.add_comment(':boom: {}'.format(desc))
+        self.add_comment(comments.TimedOut())
         self.change_labels(LabelEvent.TIMED_OUT)
 
 

homu/server.py

@@ -568,9 +568,7 @@ def report_build_res(succ, url, builder, state, logger, repo_cfg):
                 state.add_comment(comments.BuildCompleted(
                     approved_by=state.approved_by,
                     base_ref=state.base_ref,
-                    builders=dict(
-                        (k, v["url"]) for k, v in state.build_res.items()
-                    ),
+                    builders={k: v["url"] for k, v in state.build_res.items()},
                     merge_sha=state.merge_sha,
                 ))
                 state.change_labels(LabelEvent.SUCCEED)
@@ -601,9 +599,7 @@ def report_build_res(succ, url, builder, state, logger, repo_cfg):
                     state.add_comment(':eyes: ' + desc)
             else:
                 state.add_comment(comments.TryBuildCompleted(
-                    builders=dict(
-                        (k, v["url"]) for k, v in state.build_res.items()
-                    ),
+                    builders={k: v["url"] for k, v in state.build_res.items()},
                     merge_sha=state.merge_sha,
                 ))
                 state.change_labels(LabelEvent.TRY_SUCCEED)