Skip to content

Commit 4c3d446

Browse files
committed
Generates a unique rollup branch name everytime.
1 parent c889ee6 commit 4c3d446

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

cfg.sample.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ try_users = []
9696
#
9797
#auto = "auto"
9898
#try = "try"
99-
#rollup = "rollup"
10099

101100
[repo.NAME.github]
102101
# Arbitrary secret. You can generate one with: openssl rand -hex 20

homu/server.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import os
3131
import traceback
3232
from retrying import retry
33+
import uuid
3334

3435
import bottle
3536
bottle.BaseRequest.MEMFILE_MAX = 1024 * 1024 * 10
@@ -241,9 +242,10 @@ def rollup(user_gh, state, repo_label, repo_cfg, repo):
241242
base_ref = rollup_states[0].base_ref
242243

243244
base_sha = repo.ref('heads/' + base_ref).object.sha
245+
branch_name = 'rollup-' + str(uuid.uuid4())
244246
utils.github_set_ref(
245247
user_repo,
246-
'heads/' + repo_cfg.get('branch', {}).get('rollup', 'rollup'),
248+
'heads/' + branch_name,
247249
base_sha,
248250
force=True,
249251
)
@@ -265,8 +267,7 @@ def rollup(user_gh, state, repo_label, repo_cfg, repo):
265267
)
266268

267269
try:
268-
rollup = repo_cfg.get('branch', {}).get('rollup', 'rollup')
269-
user_repo.merge(rollup, state.head_sha, merge_msg)
270+
user_repo.merge(branch_name, state.head_sha, merge_msg)
270271
except github3.models.GitHubError as e:
271272
if e.code != 409:
272273
raise
@@ -286,11 +287,10 @@ def rollup(user_gh, state, repo_label, repo_cfg, repo):
286287
body += '\nr? @ghost'
287288

288289
try:
289-
rollup = repo_cfg.get('branch', {}).get('rollup', 'rollup')
290290
pull = base_repo.create_pull(
291291
title,
292292
state.base_ref,
293-
user_repo.owner.login + ':' + rollup,
293+
user_repo.owner.login + ':' + branch_name,
294294
body,
295295
)
296296
except github3.models.GitHubError as e:

0 commit comments

Comments
 (0)