override the configs directory inside docker

Author: pietroalbini

Dockerfile

@@ -17,5 +17,6 @@ RUN pip install .
 
 EXPOSE 80
 ENV HIGHFIVE_PORT 80
+ENV HIGHFIVE_CONFIG_DIR /highfive/highfive/configs
 
 CMD highfive

highfive/app.py

@@ -13,7 +13,7 @@
 import waitress
 
 
-def create_app(config, webhook_secret=None):
+def create_app(config, webhook_secret=None, config_dir=None):
     app = flask.Flask(__name__)
 
     # The canonical URL is /webhook, but other URLs are accepted for backward
@@ -41,7 +41,7 @@ def new_pr():
         except (KeyError, ValueError), _:
             return 'Error: missing or invalid payload\n', 400
         try:
-            handler = HighfiveHandler(Payload(payload), config)
+            handler = HighfiveHandler(Payload(payload), config, config_dir)
             return handler.run(flask.request.headers['X-GitHub-Event'])
         except UnsupportedRepoError:
             return 'Error: this repository is not configured!\n', 400
@@ -57,15 +57,16 @@ def index():
 @click.option('--port', default=8000)
 @click.option('--github-token', required=True)
 @click.option("--webhook-secret")
-def cli(port, github_token, webhook_secret):
+@click.option("--config-dir")
+def cli(port, github_token, webhook_secret, config_dir):
     try:
         config = Config(github_token)
     except InvalidTokenException:
         print 'error: invalid github token provided!'
         sys.exit(1)
     print 'Found a valid GitHub token for user @' + config.github_username
 
-    app = create_app(config, webhook_secret)
+    app = create_app(config, webhook_secret, config_dir)
     waitress.serve(app, port=port)
 
 

highfive/newpr.py

@@ -47,19 +47,19 @@ class UnsupportedRepoError(IOError):
     pass
 
 class HighfiveHandler(object):
-    def __init__(self, payload, config):
+    def __init__(self, payload, config, config_dir=None):
         self.payload = payload
 
         self.integration_user = config.github_username
         self.integration_token = config.github_token
 
-        self.repo_config = self.load_repo_config()
+        self.repo_config = self.load_repo_config(config_dir)
 
-    def load_repo_config(self):
+    def load_repo_config(self, config_dir):
         '''Load the repository configuration.'''
         (org, repo) = self.payload['repository', 'full_name'].split('/')
         try:
-            return self._load_json_file(os.path.join(org, repo) + '.json')
+            return self._load_json_file(config_dir, os.path.join(org, repo) + '.json')
         except IOError:
             raise UnsupportedRepoError
 
@@ -75,10 +75,11 @@ def run(self, event):
         else:
             return 'Unsupported webhook event.\n'
 
-    def _load_json_file(self, name):
-        configs_dir = os.path.join(os.path.dirname(__file__), 'configs')
+    def _load_json_file(self, config_dir, name):
+        if not config_dir:
+            config_dir = os.path.join(os.path.dirname(__file__), 'configs')
 
-        with open(os.path.join(configs_dir, name)) as config:
+        with open(os.path.join(config_dir, name)) as config:
             return json.load(config)
 
     def modifies_submodule(self, diff):