Remove HashSet Add and AddAssign implementations

Author: ToMe25

benches/set_ops.rs

@@ -52,16 +52,6 @@ fn set_ops_bit_xor(b: &mut Bencher) {
     b.iter(|| &large_set ^ &small_set)
 }
 
-#[bench]
-fn set_ops_add(b: &mut Bencher) {
-    let large_set: HashSet<_> = (0..LARGE_SET_SIZE).map(|nr| format!("key{}", nr)).collect();
-    let small_set: HashSet<_> = ((LARGE_SET_SIZE - OVERLAPP)
-        ..(LARGE_SET_SIZE + SMALL_SET_SIZE - OVERLAPP))
-        .map(|nr| format!("key{}", nr))
-        .collect();
-    b.iter(|| &large_set + &small_set)
-}
-
 #[bench]
 fn set_ops_sub_large_small(b: &mut Bencher) {
     let large_set: HashSet<_> = (0..LARGE_SET_SIZE).map(|nr| format!("key{}", nr)).collect();
@@ -124,20 +114,6 @@ fn set_ops_bit_xor_assign(b: &mut Bencher) {
     });
 }
 
-#[bench]
-fn set_ops_add_assign(b: &mut Bencher) {
-    let large_set: HashSet<_> = (0..LARGE_SET_SIZE).map(|nr| format!("key{}", nr)).collect();
-    let small_set: HashSet<_> = ((LARGE_SET_SIZE - OVERLAPP)
-        ..(LARGE_SET_SIZE + SMALL_SET_SIZE - OVERLAPP))
-        .map(|nr| format!("key{}", nr))
-        .collect();
-    b.iter(|| {
-        let mut set = large_set.clone();
-        set += &small_set;
-        set
-    });
-}
-
 #[bench]
 fn set_ops_sub_assign_large_small(b: &mut Bencher) {
     let large_set: HashSet<_> = (0..LARGE_SET_SIZE).map(|nr| format!("key{}", nr)).collect();

src/set.rs

@@ -5,9 +5,7 @@ use alloc::borrow::ToOwned;
 use core::fmt;
 use core::hash::{BuildHasher, Hash};
 use core::iter::{Chain, FusedIterator};
-use core::ops::{
-    Add, AddAssign, BitAnd, BitAndAssign, BitOr, BitOrAssign, BitXor, BitXorAssign, Sub, SubAssign,
-};
+use core::ops::{BitAnd, BitAndAssign, BitOr, BitOrAssign, BitXor, BitXorAssign, Sub, SubAssign};
 
 use super::map::{self, DefaultHashBuilder, HashMap, Keys};
 use crate::raw::{Allocator, Global, RawExtractIf};
@@ -1504,38 +1502,6 @@ where
     }
 }
 
-impl<T, S> Add<&HashSet<T, S>> for &HashSet<T, S>
-where
-    T: Eq + Hash + Clone,
-    S: BuildHasher + Default,
-{
-    type Output = HashSet<T, S>;
-
-    /// Returns the union of `self` and `rhs` as a new `HashSet<T, S>`.
-    ///
-    /// # Examples
-    ///
-    /// ```
-    /// use hashbrown::HashSet;
-    ///
-    /// let a: HashSet<_> = vec![1, 2, 3].into_iter().collect();
-    /// let b: HashSet<_> = vec![2, 3, 4].into_iter().collect();
-    ///
-    /// let set = &a + &b;
-    ///
-    /// let mut i = 0;
-    /// let expected = [1, 2, 3, 4];
-    /// for x in &set {
-    ///     assert!(expected.contains(x));
-    ///     i += 1;
-    /// }
-    /// assert_eq!(i, expected.len());
-    /// ```
-    fn add(self, rhs: &HashSet<T, S>) -> HashSet<T, S> {
-        self.union(rhs).cloned().collect()
-    }
-}
-
 impl<T, S> Sub<&HashSet<T, S>> for &HashSet<T, S>
 where
     T: Eq + Hash + Clone,
@@ -1672,40 +1638,6 @@ where
     }
 }
 
-impl<T, S> AddAssign<&HashSet<T, S>> for HashSet<T, S>
-where
-    T: Eq + Hash + Clone,
-    S: BuildHasher,
-{
-    /// Modifies this set to contain the union of `self` and `rhs`.
-    ///
-    /// # Examples
-    ///
-    /// ```
-    /// use hashbrown::HashSet;
-    ///
-    /// let mut a: HashSet<_> = vec![1, 2, 3].into_iter().collect();
-    /// let b: HashSet<_> = vec![2, 3, 4].into_iter().collect();
-    ///
-    /// a += &b;
-    ///
-    /// let mut i = 0;
-    /// let expected = [1, 2, 3, 4];
-    /// for x in &a {
-    ///     assert!(expected.contains(x));
-    ///     i += 1;
-    /// }
-    /// assert_eq!(i, expected.len());
-    /// ```
-    fn add_assign(&mut self, rhs: &HashSet<T, S>) {
-        for item in rhs {
-            if !self.contains(item) {
-                self.insert(item.clone());
-            }
-        }
-    }
-}
-
 impl<T, S> SubAssign<&HashSet<T, S>> for HashSet<T, S>
 where
     T: Eq + Hash + Clone,