Adjust Debug implementations

Author: taiki-e

futures-channel/src/mpsc/mod.rs

@@ -168,11 +168,11 @@ pub struct TryRecvError {
 }
 
 impl fmt::Display for SendError {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         if self.is_full() {
-            write!(fmt, "send failed because channel is full")
+            write!(f, "send failed because channel is full")
         } else {
-            write!(fmt, "send failed because receiver is gone")
+            write!(f, "send failed because receiver is gone")
         }
     }
 }
@@ -198,19 +198,19 @@ impl SendError {
 }
 
 impl<T> fmt::Debug for TrySendError<T> {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-        fmt.debug_struct("TrySendError")
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("TrySendError")
             .field("kind", &self.err.kind)
             .finish()
     }
 }
 
 impl<T> fmt::Display for TrySendError<T> {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         if self.is_full() {
-            write!(fmt, "send failed because channel is full")
+            write!(f, "send failed because channel is full")
         } else {
-            write!(fmt, "send failed because receiver is gone")
+            write!(f, "send failed because receiver is gone")
         }
     }
 }
@@ -240,15 +240,15 @@ impl<T> TrySendError<T> {
 }
 
 impl fmt::Debug for TryRecvError {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-        fmt.debug_tuple("TryRecvError")
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_tuple("TryRecvError")
             .finish()
     }
 }
 
 impl fmt::Display for TryRecvError {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(fmt, "receiver channel is empty")
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        write!(f, "receiver channel is empty")
     }
 }
 

futures-channel/src/oneshot.rs

@@ -382,8 +382,8 @@ impl<T> Drop for Sender<T> {
 pub struct Canceled;
 
 impl fmt::Display for Canceled {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(fmt, "oneshot canceled")
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        write!(f, "oneshot canceled")
     }
 }
 

futures-core/src/task/__internal/atomic_waker.rs

@@ -313,8 +313,8 @@ impl Default for AtomicWaker {
 }
 
 impl fmt::Debug for AtomicWaker {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(fmt, "AtomicWaker")
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        write!(f, "AtomicWaker")
     }
 }
 

futures-util/src/compat/compat01as03.rs

@@ -307,6 +307,7 @@ where
 
 struct NotifyWaker(task03::Waker);
 
+#[allow(missing_debug_implementations)] // false positive: this is private type
 #[derive(Clone)]
 struct WakerToHandle<'a>(&'a task03::Waker);
 

futures-util/src/compat/executor.rs

@@ -60,7 +60,7 @@ where Ex: Executor01<Executor01Future> + Clone + Send + 'static
 
 /// Converts a futures 0.1 [`Executor`](futures_01::future::Executor) into a
 /// futures 0.3 [`Spawn`](futures_core::task::Spawn).
-#[derive(Clone)]
+#[derive(Debug, Clone)]
 pub struct Executor01As03<Ex> {
     executor01: Ex
 }

futures-util/src/compat/mod.rs

@@ -3,8 +3,6 @@
 //! This module is only available when the `compat` feature of this
 //! library is activated.
 
-#![allow(missing_debug_implementations)]
-
 mod executor;
 pub use self::executor::{Executor01CompatExt, Executor01Future, Executor01As03};
 

futures-util/src/future/flatten.rs

@@ -31,8 +31,8 @@ impl<Fut> fmt::Debug for Flatten<Fut>
     where Fut: Future + fmt::Debug,
           Fut::Output: Future + fmt::Debug,
 {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-        fmt.debug_struct("Flatten")
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("Flatten")
             .field("state", &self.state)
             .finish()
     }

futures-util/src/future/flatten_stream.rs

@@ -25,8 +25,8 @@ impl<Fut> fmt::Debug for FlattenStream<Fut>
     where Fut: Future + fmt::Debug,
           Fut::Output: fmt::Debug,
 {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-        fmt.debug_struct("FlattenStream")
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("FlattenStream")
             .field("state", &self.state)
             .finish()
     }

futures-util/src/future/join.rs

@@ -26,8 +26,8 @@ macro_rules! generate {
                 $Fut::Output: fmt::Debug,
             )*
         {
-            fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-                fmt.debug_struct(stringify!($Join))
+            fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+                f.debug_struct(stringify!($Join))
                     $(.field(stringify!($Fut), &self.$Fut))*
                     .finish()
             }

futures-util/src/future/join_all.rs

@@ -70,8 +70,8 @@ where
     F: Future + fmt::Debug,
     F::Output: fmt::Debug,
 {
-    fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
-        fmt.debug_struct("JoinAll")
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("JoinAll")
             .field("elems", &self.elems)
             .finish()
     }