Display "Go to latest stable" for pre-release

closes #1044

Author: robinhundt

src/web/mod.rs

@@ -348,11 +348,12 @@ fn match_version(
         for version in versions.iter().filter(|(_, _, yanked)| !yanked) {
             // in theory a crate must always have a semver compatible version,
             // but check result just in case
-            let version_sem = Version::parse(&version.0).map_err(|_| {
+            let version_sem = Version::parse(&version.0).map_err(|err| {
                 log::error!(
-                    "invalid semver in database for crate {}: {}",
+                    "invalid semver in database for crate {}: {}. Err: {}",
                     name,
-                    version.0
+                    version.0,
+                    err
                 );
                 Nope::InternalServerError
             })?;

src/web/rustdoc.rs

@@ -189,6 +189,7 @@ struct RustdocPage {
     latest_version: String,
     inner_path: String,
     is_latest_version: bool,
+    is_prerelease: bool,
     krate: CrateDetails,
 }
 
@@ -367,6 +368,19 @@ pub fn rustdoc_html_server_handler(req: &mut Request) -> IronResult<Response> {
     // Get the latest version of the crate
     let latest_version = latest_release.version.to_string();
     let is_latest_version = latest_version == version;
+    let is_prerelease = semver::Version::parse(&version)
+        // should be impossible unless there is a semver incompatible version in the db
+        // Note that there is a redirect earlier for semver matches to the exact version
+        .map_err(|err| {
+            log::error!(
+                "invalid semver in database for crate {}: {}. Err: {}",
+                name,
+                &version,
+                err
+            );
+            IronError::new(Nope::InternalServerError, status::InternalServerError)
+        })?
+        .is_prerelease();
 
     // If the requested crate version is the most recent, use it to build the url
     let latest_path = if is_latest_version {
@@ -408,6 +422,7 @@ pub fn rustdoc_html_server_handler(req: &mut Request) -> IronResult<Response> {
         latest_version,
         inner_path,
         is_latest_version,
+        is_prerelease,
         krate,
     }
     .into_response(&file.0.content, config.max_parse_memory, req, &path)

templates/rustdoc/header.html

@@ -181,23 +181,24 @@
                             </span>
                         </li>
 
-                    {# If the crate isn't the latest & is yanked, display a warning and offer a link to the latest release #}
-                    {%- elif not is_latest_version and krate.yanked -%}
-                        <li class="pure-menu-item">
-                            <a href="{{ latest_path | safe }}" class="pure-menu-link warn"
-                                title="You are seeing a yanked version of {{ krate.name }} crate. Click here to go to latest version.">
-                                {{ "exclamation-triangle" | fas(fw=true) }}
-                                <span class="title"> This release has been yanked, go to latest version</span>
-                            </a>
-                        </li>
-
-                    {# If this isn't the most recent release, offer a link to the latest #}
+                    {# If this isn't the most recent stable release, offer a link to the latest #}
                     {%- elif not is_latest_version -%}
+                        {%- if krate.yanked -%}
+                            {%- set tooltip = "You are seeing a yanked version of the " ~ krate.name ~ "crate. Click here to go to the latest version." -%}
+                            {%- set title = "This release has been yanked, go to latest version" -%}
+                        {%- elif is_prerelease -%}
+                            {%- set tooltip = "You are seeing a pre-release version of the " ~ krate.name ~ "crate. Click here to go to the latest stable version." -%}
+                            {%- set title = "Go to latest stable release" -%}
+                        {%- else -%}
+                            {%- set tooltip = "You are seeing an outdated version of the " ~ krate.name ~ "crate. Click here to go to the latest version." -%}
+                            {%- set title = "Go to latest version" -%}
+                        {%- endif -%}
+
                         <li class="pure-menu-item">
                             <a href="{{ latest_path | safe }}" class="pure-menu-link warn"
-                                title="You are seeing an outdated version of {{ krate.name }} crate. Click here to go to latest version.">
+                                title="{{ tooltip }}">
                                 {{ "exclamation-triangle" | fas(fw=true) }}
-                                <span class="title"> Go to latest version</span>
+                                <span class="title">{{ title }}</span>
                             </a>
                         </li>
                     {%- endif -%}