Fix count of feature flags by ignoring "default"

Author: GuillaumeGomez

src/web/crate_details.rs

@@ -1740,7 +1740,7 @@ mod tests {
             let def_len = page
                 .select_first(r#"b[data-id="default-feature-len"]"#)
                 .unwrap();
-            assert_eq!(def_len.text_contents(), "3");
+            assert_eq!(def_len.text_contents(), "2");
             Ok(())
         });
     }

src/web/features.rs

@@ -123,6 +123,17 @@ impl FeaturesPage {
             .filter(|f| !f.starts_with("dep:") && *f != "default" && !f.contains('/'))
             .count()
     }
+
+    pub(crate) fn nb_features(&self) -> usize {
+        let Some(features) = &self.sorted_features else {
+            return 0;
+        };
+        if features.iter().any(|f| f.name == "default") {
+            features.len() - 1
+        } else {
+            features.len()
+        }
+    }
 }
 
 pub(crate) async fn build_features_handler(
@@ -505,7 +516,7 @@ mod tests {
             // (`whatever/wut`).
             assert_eq!(
                 text,
-                "This version has 3 feature flags, 1 of them enabled by default."
+                "This version has 2 feature flags, 1 of them enabled by default."
             );
 
             Ok(())

templates/crate/features.html

@@ -65,7 +65,7 @@ <h1>{{ metadata.name }}</h1>
                     {%- if features.is_empty() -%}
                         <p data-id="empty-features">This release does not have any feature flags.</p>
                     {%- else -%}
-                        <p>This version has <b>{{ features.len() }}</b> feature flags, <b data-id="default-feature-len">{{ nb_enabled_default_features() }}</b> of them enabled by <b>default</b>.</p>
+                        <p>This version has <b>{{ nb_features() }}</b> feature flags, <b data-id="default-feature-len">{{ nb_enabled_default_features() }}</b> of them enabled by <b>default</b>.</p>
                         {%- for feature in features -%}
                             {%- let is_default = feature.name != "default" && is_default_feature(feature.name) -%}
                             <h3 id="{{ feature.name }}">{{ feature.name }}{%- if is_default  %} (default){%- endif -%}</h3>