redirect to crate-page trying to access rustdoc pages on failed releases

Author: syphar

src/web/crate_details.rs

@@ -38,7 +38,7 @@ pub struct CrateDetails {
     release_time: DateTime<Utc>,
     build_status: bool,
     last_successful_build: Option<String>,
-    rustdoc_status: bool,
+    pub rustdoc_status: bool,
     pub archive_storage: bool,
     repository_url: Option<String>,
     homepage_url: Option<String>,

src/web/rustdoc.rs

@@ -473,6 +473,15 @@ pub(crate) async fn rustdoc_html_server_handler(
     .await?
     .ok_or(AxumNope::ResourceNotFound)?;
 
+    if !krate.rustdoc_status {
+        rendering_time.step("redirect to crate");
+        return Ok(axum_cached_redirect(
+            format!("/crate/{}/{}", params.name, version_or_latest),
+            CachePolicy::ForeverInCdn,
+        )?
+        .into_response());
+    }
+
     // if visiting the full path to the default target, remove the target from the path
     // expects a req_path that looks like `[/:target]/.*`
     if req_path.first().copied() == Some(&krate.metadata.default_target) {
@@ -2589,4 +2598,28 @@ mod test {
             Ok(())
         })
     }
+
+    #[test_case("/something/1.2.3/some_path/", "/crate/something/1.2.3")]
+    #[test_case("/something/latest/some_path/", "/crate/something/latest")]
+    fn rustdoc_page_from_failed_build_redirects_to_crate(path: &str, expected: &str) {
+        wrapper(|env| {
+            env.fake_release()
+                .name("something")
+                .version("1.2.3")
+                .archive_storage(true)
+                .build_result_failed()
+                .create()?;
+            let web = env.frontend();
+
+            assert_redirect_cached(
+                path,
+                expected,
+                CachePolicy::ForeverInCdn,
+                web,
+                &env.config(),
+            )?;
+
+            Ok(())
+        })
+    }
 }