Remove krate methods

Author: GuillaumeGomez

src/web/build_details.rs

@@ -2,7 +2,6 @@ use crate::{
     db::types::BuildStatus,
     impl_axum_webpage,
     web::{
-        crate_details::CrateDetails,
         error::{AxumNope, AxumResult},
         extractors::{DbConnection, Path},
         file::File,
@@ -45,9 +44,6 @@ impl_axum_webpage! { BuildDetailsPage }
 
 // Used for template rendering.
 impl BuildDetailsPage {
-    pub(crate) fn krate(&self) -> Option<&CrateDetails> {
-        None
-    }
     pub(crate) fn get_metadata(&self) -> Option<&MetaData> {
         Some(&self.metadata)
     }

src/web/builds.rs

@@ -9,7 +9,6 @@ use crate::{
     impl_axum_webpage,
     utils::spawn_blocking,
     web::{
-        crate_details::CrateDetails,
         error::AxumResult,
         extractors::{DbConnection, Path},
         filters, match_version, MetaData, ReqVersion,
@@ -55,9 +54,6 @@ struct BuildsPage {
 impl_axum_webpage! { BuildsPage }
 
 impl BuildsPage {
-    pub(crate) fn krate(&self) -> Option<&CrateDetails> {
-        None
-    }
     pub(crate) fn get_metadata(&self) -> Option<&MetaData> {
         Some(&self.metadata)
     }

src/web/crate_details.rs

@@ -426,10 +426,6 @@ impl_axum_webpage! {
 
 // Used by templates.
 impl CrateDetailsPage {
-    pub(crate) fn krate(&self) -> Option<&CrateDetails> {
-        None
-    }
-
     pub(crate) fn get_metadata(&self) -> Option<&MetaData> {
         Some(&self.details.metadata)
     }

src/web/features.rs

@@ -3,7 +3,6 @@ use crate::{
     impl_axum_webpage,
     web::{
         cache::CachePolicy,
-        crate_details::CrateDetails,
         error::{AxumNope, AxumResult},
         extractors::{DbConnection, Path},
         filters,
@@ -113,9 +112,6 @@ impl_axum_webpage! {
 }
 
 impl FeaturesPage {
-    pub(crate) fn krate(&self) -> Option<&CrateDetails> {
-        None
-    }
     pub(crate) fn get_metadata(&self) -> Option<&MetaData> {
         Some(&self.metadata)
     }

src/web/page/templates.rs

@@ -1,4 +1,5 @@
 use crate::error::Result;
+use crate::web::crate_details::CrateDetails;
 use crate::web::rustdoc::RustdocPage;
 use crate::web::MetaData;
 use anyhow::Context;
@@ -33,13 +34,15 @@ pub struct Body;
 pub struct Topbar<'a> {
     inner: &'a RustdocPage,
     permalink_path: &'a str,
+    krate: &'a CrateDetails,
 }
 
 impl<'a> Topbar<'a> {
     pub fn new(inner: &'a RustdocPage) -> Self {
         Self {
             inner,
             permalink_path: &inner.permalink_path,
+            krate: &inner.krate,
         }
     }
 

src/web/rustdoc.rs

@@ -313,11 +313,6 @@ impl RustdocPage {
             .into_response())
     }
 
-    // Used for template rendering.
-    pub(crate) fn krate(&self) -> Option<&CrateDetails> {
-        Some(&self.krate)
-    }
-
     pub(crate) fn use_direct_platform_links(&self) -> bool {
         !self.latest_path.contains("/target-redirect/")
     }

src/web/source.rs

@@ -4,8 +4,8 @@ use crate::{
     impl_axum_webpage,
     storage::PathNotFoundError,
     web::{
-        cache::CachePolicy, crate_details::CrateDetails, error::AxumNope, extractors::Path,
-        file::File as DbFile, filters, headers::CanonicalUrl, MetaData, ReqVersion,
+        cache::CachePolicy, error::AxumNope, extractors::Path, file::File as DbFile, filters,
+        headers::CanonicalUrl, MetaData, ReqVersion,
     },
     AsyncStorage,
 };
@@ -174,9 +174,6 @@ impl SourcePage {
     pub(crate) fn get_metadata(&self) -> Option<&MetaData> {
         Some(&self.metadata)
     }
-    pub(crate) fn krate(&self) -> Option<&CrateDetails> {
-        None
-    }
     pub(crate) fn use_direct_platform_links(&self) -> bool {
         true
     }

templates/rustdoc/topbar.html

@@ -16,7 +16,7 @@
             "version": {{ metadata.version|json_encode|safe }}
         }
     </script>
-    {%- if let Some(krate) = krate() -%}
+    {%- if krate is defined -%}
         <li class="pure-menu-item pure-menu-has-children">
             <a href="#" class="pure-menu-link crate-name" title="{{ krate.description.as_deref().unwrap_or_default() }}">
                 {{ "cube"|fas(false, false, "") }}