Skip to content

Commit 10145f6

Browse files
notriddleJoshua Nelson
authored andcommitted
Fix tabbing through the giant crate menu
Without this tabindex attribute, the scroll view itself gets selected. With this attribute added, focus jumps straight to the menu item within, which is what we want, since it contains nothing but menu items, and most of the keyboard shortcuts you would use to interact with the scroll view are trapped by JavaScript anyway.
1 parent 890f06f commit 10145f6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

templates/rustdoc/topbar.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113

114114
{# Display all dependencies that the crate has #}
115115
<li class="pure-menu-item">
116-
<div class="pure-menu pure-menu-scrollable sub-menu">
116+
<div class="pure-menu pure-menu-scrollable sub-menu" tabindex="-1">
117117
<ul class="pure-menu-list">
118118
{%- for dep in krate.dependencies -%}
119119
<li class="pure-menu-item">
@@ -134,7 +134,7 @@
134134
<li class="pure-menu-heading">Versions</li>
135135

136136
<li class="pure-menu-item">
137-
<div class="pure-menu pure-menu-scrollable sub-menu">
137+
<div class="pure-menu pure-menu-scrollable sub-menu" tabindex="-1">
138138
<ul class="pure-menu-list">
139139
{# Display all releases of this crate #}
140140
{{ macros::releases_list(name=krate.name, releases=krate.releases, target=target, inner_path=inner_path) }}

0 commit comments

Comments
 (0)