Auto merge of #4311 - Turbo87:redirect, r=locks

bors · bors · commit e4e3802ca9f1 · 2021-12-22T10:39:57.000Z
Adjust `/me` redirection to `/settings/tokens` As discussed on Discord, the `cargo login` command is showing links to https://crates.io/me to access the API tokens. Since that is probably more important than any other bookmarks and has backwards compatibility concerns this PR is changing the `/me` redirection to `/settings/tokens` (instead of `/settings` aka. `/settings/profile`).
diff --git a/app/routes/me/index.js b/app/routes/me/index.js
@@ -5,6 +5,8 @@ export default class MeIndexRoute extends Route {
   @service router;
 
   redirect() {
-    this.router.replaceWith('settings');
+    // `cargo login` is showing links to https://crates.io/me to access the API tokens,
+    // so we need to keep this route and redirect the user to the API tokens settings page.
+    this.router.replaceWith('settings.tokens');
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,8 @@ export default class MeIndexRoute extends Route {`
`5`	`5`	`@service router;`
`6`	`6`
`7`	`7`	`redirect() {`
`8`		`- this.router.replaceWith('settings');`
	`8`	+ // `cargo login` is showing links to https://crates.io/me to access the API tokens,
	`9`	`+ // so we need to keep this route and redirect the user to the API tokens settings page.`
	`10`	`+ this.router.replaceWith('settings.tokens');`
`9`	`11`	`}`
`10`	`12`	`}`