Auto merge of #4250 - Turbo87:error-route, r=Turbo87

Replace custom error route implementation with `ember-error-route`

see https://github.com/simplabs/ember-error-route

This is essentially the exact same implementation that we have already been using, but in a reusable package :)

Author: bors

app/routes/catch-all.js

@@ -1,73 +1,3 @@
-import Route from '@ember/routing/route';
-import { inject as service } from '@ember/service';
+import ErrorRoute from 'ember-error-route';
 
-/**
- * This is a weird route... but let me explain.
- *
- * This is the default route that gets used if no other matching route is found.
- *
- * This route is *also* used as a generic error page via:
- *
- * ```js
- * this.router.replaceWith('catch-all', { transition, title: 'Something failed' });
- * ```
- *
- * Ideally we would use the `error` substate/routes of Ember.js, but those don't
- * update the URL when an error happens. This causes the native back button of the
- * browser to behave in strange way, so we avoid using the broken built-in error
- * routes.
- */
-export default class CatchAllRoute extends Route {
-  @service router;
-
-  /**
-   * If `transitionTo('catch-all', 'foo')` is used, this hook will not get called.
-   * If the second argument is an object, then the second object will be the `model`
-   * of this route, and the `serialize()` hook gets called to figure out what the
-   * URL of this route should be. The URL is automatically assembled from the passed-in
-   * transition object.
-   */
-  serialize({ transition }) {
-    return { path: this.pathForRouteInfo(transition.to) };
-  }
-
-  /**
-   * This internal method takes a `RouteInfo` object from Ember.js (e.g. `transition.to`)
-   * and returns the corresponding `:path` route parameter for this `catch-all` route.
-   * @return {string}
-   */
-  pathForRouteInfo(routeInfo) {
-    let routeName = routeInfo.name;
-    let params = paramsForRouteInfo(routeInfo);
-    let queryParams = routeInfo.queryParams;
-    return this.router.urlFor(routeName, ...params, { queryParams }).slice(1);
-  }
-}
-
-/**
- * Returns all route parameters for the passed-in `RouteInfo` object.
- *
- * These can be used in `router.urlFor(...)` calls.
- */
-function paramsForRouteInfo(routeInfo) {
-  let routeInfos = [...allRouteInfos(routeInfo)].reverse();
-
-  let params = [];
-  for (let routeInfo of routeInfos) {
-    for (let paramName of routeInfo.paramNames) {
-      params.push(routeInfo.params[paramName]);
-    }
-  }
-  return params;
-}
-
-/**
- * Iterates upwards through the `RouteInfo` "family tree" until the top-most
- * `RouteInfo` is reached.
- */
-function* allRouteInfos(routeInfo) {
-  yield routeInfo;
-  while ((routeInfo = routeInfo.parent)) {
-    yield routeInfo;
-  }
-}
+export default class CatchAllRoute extends ErrorRoute {}

package.json

@@ -88,6 +88,7 @@
     "ember-css-modules": "2.0.0",
     "ember-data": "3.27.1",
     "ember-disable-prototype-extensions": "1.1.3",
+    "ember-error-route": "0.1.0",
     "ember-event-helpers": "0.1.1",
     "ember-exam": "7.0.1",
     "ember-export-application-global": "2.0.1",

yarn.lock

@@ -6775,6 +6775,14 @@ ember-disable-prototype-extensions@1.1.3:
   resolved "https://registry.yarnpkg.com/ember-disable-prototype-extensions/-/ember-disable-prototype-extensions-1.1.3.tgz#1969135217654b5e278f9fe2d9d4e49b5720329e"
   integrity sha1-GWkTUhdlS14nj5/i2dTkm1cgMp4=
 
+ember-error-route@0.1.0:
+  version "0.1.0"
+  resolved "https://registry.yarnpkg.com/ember-error-route/-/ember-error-route-0.1.0.tgz#328fb86e95401590dfeda9e18fc7b963301b0241"
+  integrity sha512-0WW3RBRvTs64wjosYP5JrqS3EjT3uM4FemF2Vm3meNdb0W++RJj+tjZqoIZVOkcqVTIzQjJzrCd9e7DJ8wxs5Q==
+  dependencies:
+    ember-cli-babel "^7.26.6"
+    ember-cli-htmlbars "^6.0.0"
+
 ember-event-helpers@0.1.1:
   version "0.1.1"
   resolved "https://registry.yarnpkg.com/ember-event-helpers/-/ember-event-helpers-0.1.1.tgz#8df141306c927b9d1a7bc63d63095e92c0ba90a1"