Move the check.

Author: LawnGnome

crates/crates_io_tarball/src/manifest.rs

@@ -7,6 +7,13 @@ pub fn validate_manifest(manifest: &Manifest) -> Result<(), Error> {
     // does not accept workspace manifests.
     let package = package.ok_or(Error::Other("missing field `package`".to_string()))?;
 
+    // We don't want to allow [patch] sections in manifests at all.
+    if matches!(&manifest.patch, Some(patch) if !patch.is_empty()) {
+        return Err(Error::Other(
+            "crates cannot be published with `[patch]` tables".to_string(),
+        ));
+    }
+
     validate_package(package)?;
 
     // These checks ensure that dependency workspace inheritance has been

src/controllers/krate/publish.rs

@@ -342,13 +342,6 @@ pub async fn publish(app: AppState, req: Parts, body: Body) -> AppResult<Json<Go
         validate_dependency(dep)?;
     }
 
-    // We don't want to allow [patch] sections in manifests at all.
-    if matches!(&tarball_info.manifest.patch, Some(patch) if !patch.is_empty()) {
-        return Err(bad_request(
-            "crates.io does not allow crates to be published with `[patch]` sections in their manifests.",
-        ));
-    }
-
     let api_token_id = auth.api_token_id();
     let user = auth.user();
 

src/tests/krate/publish/dependencies.rs

@@ -313,7 +313,7 @@ async fn new_krate_with_patch() {
 
     let response = token.publish_crate(crate_to_publish).await;
     assert_eq!(response.status(), StatusCode::BAD_REQUEST);
-    assert_snapshot!(response.text(), @r###"{"errors":[{"detail":"crates.io does not allow crates to be published with `[patch]` sections in their manifests."}]}"###);
+    assert_snapshot!(response.text(), @r###"{"errors":[{"detail":"failed to parse `Cargo.toml` manifest file\n\ncrates cannot be published with `[patch]` tables"}]}"###);
     assert_that!(app.stored_files().await, empty());
 }