Skip to content

Commit 9cc2009

Browse files
authored
og_image: Skip CDN invalidations for backfill operation (#11522)
1 parent 4129dec commit 9cc2009

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

src/bin/crates-admin/backfill_og_images.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ pub async fn run(opts: Opts) -> Result<()> {
7979
// Create batch of jobs
8080
let jobs = crate_names
8181
.into_iter()
82-
.map(GenerateOgImage::new)
82+
.map(GenerateOgImage::without_cdn_invalidation)
8383
.map(|job| {
8484
Ok((
8585
background_jobs::job_type.eq(GenerateOgImage::JOB_NAME),

src/worker/jobs/generate_og_image.rs

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,22 @@ use tracing::{error, info, instrument, warn};
1414
#[derive(Serialize, Deserialize)]
1515
pub struct GenerateOgImage {
1616
crate_name: String,
17+
invalidate_cdns: bool,
1718
}
1819

1920
impl GenerateOgImage {
2021
pub fn new(crate_name: String) -> Self {
21-
Self { crate_name }
22+
Self {
23+
crate_name,
24+
invalidate_cdns: true,
25+
}
26+
}
27+
28+
pub fn without_cdn_invalidation(crate_name: String) -> Self {
29+
Self {
30+
crate_name,
31+
invalidate_cdns: false,
32+
}
2233
}
2334
}
2435

@@ -83,6 +94,13 @@ impl BackgroundJob for GenerateOgImage {
8394
.upload_og_image(crate_name, image_bytes.into())
8495
.await?;
8596

97+
info!("Successfully generated and uploaded OG image for crate {crate_name}");
98+
99+
if !self.invalidate_cdns {
100+
info!("Skipping CDN invalidation for crate {crate_name}");
101+
return Ok(());
102+
}
103+
86104
// Invalidate CDN cache for the OG image
87105
let og_image_path = format!("og-images/{crate_name}.png");
88106

@@ -100,7 +118,7 @@ impl BackgroundJob for GenerateOgImage {
100118
}
101119
}
102120

103-
info!("Successfully generated and uploaded OG image for crate {crate_name}");
121+
info!("CDN invalidation completed for crate {crate_name}");
104122

105123
Ok(())
106124
}

0 commit comments

Comments
 (0)