Auto merge of #4356 - Turbo87:github-svg, r=Turbo87

Remove duplicate GitHub logo SVG

There is no need to have this twice... 😅

Author: bors

app/components/crate-sidebar/link.hbs

@@ -4,7 +4,7 @@
     {{#if this.isDocsRs}}
       {{svg-jar "docs-rs" local-class="icon" data-test-icon="docs-rs"}}
     {{else if this.isGitHub}}
-      {{svg-jar "GitHub-Mark" local-class="icon" data-test-icon="github"}}
+      {{svg-jar "github" local-class="icon" data-test-icon="github"}}
     {{else}}
       {{svg-jar "link" local-class="icon" data-test-icon="link"}}
     {{/if}}

app/styles/team.module.css

@@ -24,6 +24,15 @@
 
 .github-link {
     margin-left: 16px;
+
+    &, &:hover {
+        color: var(--main-color);
+    }
+
+    svg {
+        width: 32px;
+        height: 32px;
+    }
 }
 
 .results-meta {

app/styles/user.module.css

@@ -7,6 +7,17 @@
     }
 }
 
+.github-link {
+    &, &:hover {
+        color: var(--main-color);
+    }
+
+    svg {
+        width: 32px;
+        height: 32px;
+    }
+}
+
 .results-meta {
     display: flex;
     align-items: center;

app/templates/team.hbs

@@ -6,7 +6,7 @@
         {{ this.model.team.org_name }}
       </h1>
       <UserLink @user={{this.model.team}} local-class="github-link" data-test-github-link>
-        <img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark.svg">
+        {{svg-jar "github" alt="GitHub profile"}}
       </UserLink>
     </div>
     <h2 data-test-team-name>

app/templates/user.hbs

@@ -3,8 +3,8 @@
   <h1 data-test-username>
     {{ this.model.user.login }}
   </h1>
-  <UserLink @user={{this.model.user}} data-test-user-link>
-    <img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark.svg">
+  <UserLink @user={{this.model.user}} local-class="github-link" data-test-user-link>
+    {{svg-jar "github" alt="GitHub profile"}}
   </UserLink>
 </PageHeader>
 

public/assets/GitHub-Mark.svg

@@ -31,14 +31,6 @@ module('Acceptance | team page', function (hooks) {
     assert.dom('[data-test-heading] [data-test-github-link]').hasAttribute('href', 'https://github.com/org_test');
   });
 
-  test('github link has image in team header', async function (assert) {
-    this.server.loadFixtures();
-
-    await visit('/teams/github:org:thehydroimpulse');
-
-    assert.dom('[data-test-heading] [data-test-github-link] img').hasAttribute('src', '/assets/GitHub-Mark.svg');
-  });
-
   test('team organization details has github profile icon', async function (assert) {
     this.server.loadFixtures();
 

tests/acceptance/team-page-test.js

@@ -30,14 +30,6 @@ module('Acceptance | user page', function (hooks) {
     assert.dom('[data-test-heading] [data-test-user-link]').hasAttribute('href', 'https://github.com/thehydroimpulse');
   });
 
-  test('github link has image in user header', async function (assert) {
-    this.server.loadFixtures();
-
-    await visit('/users/thehydroimpulse');
-
-    assert.dom('[data-test-heading] [data-test-user-link] img').hasAttribute('src', '/assets/GitHub-Mark.svg');
-  });
-
   test('user details has github profile icon', async function (assert) {
     this.server.loadFixtures();