Auto merge of #632 - Mark-Simulacrum:fast-experiment-page, r=Mark-Simulacrum

bors · bors · commit bd39e0b51562 · 2022-05-08T15:59:18.000Z
Drop result kinds from experiment page

This is a pretty expensive query to compute, and while that could be optimized
with some amount of indexing and creative SQL, it's not clear that this table
delivers much value to the user. If we wanted to present partial reports, that
could be done on a periodic basis (e.g., creating the index.html page every
hour) and would seem largely more useful, but I don't see a clear motivation
for doing so. Triaging crater runs before they're done is unlikely to be useful.

In the meantime, it's better that the UI loads quickly than that we deliver this
data.
diff --git a/src/server/routes/ui/experiments.rs b/src/server/routes/ui/experiments.rs
@@ -1,12 +1,10 @@
 use crate::experiments::{Experiment, Mode, Status};
 use crate::prelude::*;
-use crate::report::ResultName;
 use crate::server::routes::ui::{render_template, LayoutContext};
 use crate::server::{Data, HttpError};
 use chrono::{Duration, SecondsFormat, Utc};
 use http::Response;
 use hyper::Body;
-use std::collections::HashMap;
 use std::sync::Arc;
 
 #[derive(Serialize)]
@@ -121,7 +119,6 @@ struct ExperimentExt {
 
     total_jobs: u32,
     completed_jobs: u32,
-    result_counts: Vec<(String, u32)>,
     duration: Option<String>,
     estimated_end: Option<String>,
     average_job_duration: Option<String>,
@@ -147,14 +144,6 @@ fn humanize(duration: Duration) -> String {
 pub fn endpoint_experiment(name: String, data: Arc<Data>) -> Fallible<Response<Body>> {
     if let Some(ex) = Experiment::get(&data.db, &name)? {
         let (completed_jobs, total_jobs) = ex.raw_progress(&data.db)?;
-        // this is done to avoid having tons of different test result types in the experiment page
-        // all CompilerError and DependsOn failures are grouped together
-        let mut result_counts = HashMap::new();
-        for (res, count) in ex.get_result_counts(&data.db)? {
-            *result_counts.entry(res.short_name()).or_default() += count;
-        }
-        let mut result_counts = result_counts.into_iter().collect::<Vec<_>>();
-        result_counts.sort_by(|v1, v2| (v1.0).cmp(&v2.0));
 
         let (duration, estimated_end, average_job_duration) =
             if completed_jobs > 0 && total_jobs > 0 {
@@ -198,7 +187,6 @@ pub fn endpoint_experiment(name: String, data: Arc<Data>) -> Fallible<Response<B
 
             total_jobs,
             completed_jobs,
-            result_counts,
             duration,
             estimated_end,
             average_job_duration,
diff --git a/templates/ui/experiment.html b/templates/ui/experiment.html
@@ -106,18 +106,6 @@ <h1>Experiment <b>{{ experiment.name }}</b></h1>
                         {% endif %}
                     </table>
                 </div>
-                {% if experiment.result_counts | length > 0 %}
-                <div class="card">
-                    <table class="details">
-                {% for result_count in experiment.result_counts %}
-                    <tr>
-                        <th>{{ result_count.0 }} jobs:</th>
-                        <td>{{ result_count.1}}</td>
-                    </tr>
-                {% endfor %}
-                    </table>
-                </div>
-                {% endif %}
             </div>
         </div>
     </div>
