Fix new clippy warnings

Author: Mark-Simulacrum

src/report/analyzer.rs

@@ -40,7 +40,7 @@ fn analyze_detailed(toolchain: usize, crates: Vec<CrateResult>) -> ReportCrates
     let mut root = Vec::new();
     for krate in crates {
         if let BuildFail(FailureReason::DependsOn(ref deps)) =
-            (&krate.runs[toolchain]).as_ref().unwrap().res
+            krate.runs[toolchain].as_ref().unwrap().res
         {
             for dep in deps {
                 tree.entry(dep.clone())

src/report/markdown.rs

@@ -31,7 +31,7 @@ struct ResultsContext<'a> {
 }
 
 fn write_crate(
-    mut rendered: &mut String,
+    rendered: &mut String,
     krate: &CrateResult,
     comparison: Comparison,
     is_child: bool,
@@ -76,7 +76,7 @@ fn write_crate(
         };
 
         writeln!(
-            &mut rendered,
+            rendered,
             "{}[{}{}]({}) {} {} **{}** [start]({}/log.txt) | [end]({}/log.txt)",
             prefix,
             krate.name,
@@ -90,7 +90,7 @@ fn write_crate(
         )?;
     } else {
         writeln!(
-            &mut rendered,
+            rendered,
             "{}[{}{}]({}) {} [start]({}/log.txt) | [end]({}/log.txt)",
             prefix, krate.name, status_warning, krate.url, comparison, runs[1], runs[3]
         )?;
@@ -103,10 +103,10 @@ fn render_markdown(context: &ResultsContext) -> Fallible<String> {
     let mut rendered = String::new();
 
     //add title
-    writeln!(&mut rendered, "# Crater report for {}\n\n", context.ex.name)?;
+    writeln!(rendered, "# Crater report for {}\n\n", context.ex.name)?;
 
     for (comparison, results) in context.categories.iter() {
-        writeln!(&mut rendered, "\n### {}", comparison)?;
+        writeln!(rendered, "\n### {}", comparison)?;
         match results {
             ReportCratesMD::Plain(crates) => {
                 for krate in crates {
@@ -123,7 +123,7 @@ fn render_markdown(context: &ResultsContext) -> Fallible<String> {
 
                 for (krate, deps) in orphans {
                     writeln!(
-                        &mut rendered,
+                        rendered,
                         "* [{}]({}) (not covered in crater testing)",
                         krate,
                         crate_to_url(krate)

src/server/routes/agent.rs

@@ -51,7 +51,7 @@ pub fn routes(
         .and(warp::path("next-experiment"))
         .and(warp::path::end())
         .and(mutex_filter.clone())
-        .and(github_data_filter.clone())
+        .and(github_data_filter)
         .and(auth_filter(data.clone(), TokenType::Agent))
         .map(endpoint_next_experiment);
 

src/toolchain.rs

@@ -118,7 +118,7 @@ impl FromStr for Toolchain {
         for part in parts {
             if let Some(equal_idx) = part.find('=') {
                 let (flag, value_with_equal) = part.split_at(equal_idx);
-                let value = (&value_with_equal[1..]).to_string();
+                let value = value_with_equal[1..].to_string();
 
                 if value.is_empty() {
                     return Err(ToolchainParseError::InvalidFlag(flag.to_string()));