Skip to content

Commit 1208bbf

Browse files
committed
use ToolchainSelect instead of usize to select toolchain in ReportConfig
1 parent 780f544 commit 1208bbf

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

src/report/analyzer.rs

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,14 @@ use crate::results::{
77
use std::collections::BTreeSet;
88
use std::collections::HashMap;
99

10+
pub enum ToolchainSelect {
11+
Start,
12+
End,
13+
}
14+
1015
pub enum ReportConfig {
1116
Simple,
12-
Complete { toolchain: usize },
17+
Complete(ToolchainSelect),
1318
}
1419

1520
#[cfg_attr(test, derive(Debug, PartialEq))]
@@ -85,8 +90,10 @@ pub fn analyze_report(test: RawTestResults) -> TestResults {
8590

8691
let mut categories = HashMap::new();
8792
for (cat, crates) in comparison {
88-
if let ReportConfig::Complete { toolchain } = cat.report_config() {
89-
categories.insert(cat, analyze_detailed(toolchain, crates));
93+
if let ReportConfig::Complete(toolchain) = cat.report_config() {
94+
// variants in an enum are numbered following an
95+
// increasing sequence starting from 0
96+
categories.insert(cat, analyze_detailed(toolchain as usize, crates));
9097
} else {
9198
categories.insert(cat, ReportCrates::Plain(crates));
9299
}

src/report/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use crate::config::Config;
22
use crate::crates::Crate;
33
use crate::experiments::Experiment;
44
use crate::prelude::*;
5-
use crate::report::analyzer::{analyze_report, ReportConfig};
5+
use crate::report::analyzer::{analyze_report, ReportConfig, ToolchainSelect};
66
use crate::results::{EncodedLog, EncodingType, FailureReason, ReadResults, TestResult};
77
use crate::toolchain::Toolchain;
88
use crate::utils;
@@ -91,8 +91,8 @@ impl Comparison {
9191

9292
pub fn report_config(self) -> ReportConfig {
9393
match self {
94-
Comparison::Regressed => ReportConfig::Complete { toolchain: 1 },
95-
Comparison::Fixed => ReportConfig::Complete { toolchain: 0 },
94+
Comparison::Regressed => ReportConfig::Complete(ToolchainSelect::End),
95+
Comparison::Fixed => ReportConfig::Complete(ToolchainSelect::Start),
9696
Comparison::Unknown
9797
| Comparison::Error
9898
| Comparison::SpuriousRegressed

0 commit comments

Comments
 (0)