categorize docker errors as spurious

Author: Skgland

src/report/display.rs

@@ -13,6 +13,7 @@ impl ResultName for FailureReason {
             FailureReason::Unknown => "failed (unknown)".into(),
             FailureReason::Timeout => "timed out".into(),
             FailureReason::NetworkAccess => "network access".into(),
+            FailureReason::Docker => "docker".into(),
             FailureReason::OOM => "OOM".into(),
             FailureReason::ICE => "ICE".into(),
             FailureReason::NoSpace => "no space left on device".into(),
@@ -27,6 +28,7 @@ impl ResultName for FailureReason {
             FailureReason::CompilerError(_) | FailureReason::DependsOn(_) => self.to_string(),
             FailureReason::Unknown
             | FailureReason::NetworkAccess
+            | FailureReason::Docker
             | FailureReason::Timeout
             | FailureReason::OOM
             | FailureReason::NoSpace

src/results/mod.rs

@@ -200,6 +200,7 @@ pub enum FailureReason {
     Timeout,
     ICE,
     NetworkAccess,
+    Docker,
     CompilerDiagnosticChange,
     CompilerError(BTreeSet<DiagnosticCode>),
     DependsOn(BTreeSet<Crate>),
@@ -216,6 +217,7 @@ impl ::std::fmt::Display for FailureReason {
             FailureReason::Timeout => write!(f, "timeout"),
             FailureReason::ICE => write!(f, "ice"),
             FailureReason::NetworkAccess => write!(f, "network-access"),
+            FailureReason::Docker => write!(f, "docker"),
             FailureReason::CompilerError(codes) => write!(
                 f,
                 "compiler-error({})",
@@ -283,6 +285,7 @@ impl FailureReason {
             | FailureReason::NoSpace
             | FailureReason::Timeout
             | FailureReason::NetworkAccess
+            | FailureReason::Docker
             | FailureReason::CompilerDiagnosticChange => true,
             FailureReason::CompilerError(_)
             | FailureReason::DependsOn(_)

src/runner/test.rs

@@ -17,13 +17,23 @@ use std::io::ErrorKind;
 
 fn failure_reason(err: &Error) -> FailureReason {
     for cause in err.chain() {
-        if let Some(&CommandError::SandboxOOM) = cause.downcast_ref() {
-            return FailureReason::OOM;
-        } else if let Some(&CommandError::NoOutputFor(_) | &CommandError::Timeout(_)) =
-            cause.downcast_ref()
-        {
-            return FailureReason::Timeout;
-        } else if let Some(reason) = cause.downcast_ref::<FailureReason>() {
+        if let Some(command_error) = cause.downcast_ref::<CommandError>() {
+            match command_error {
+                CommandError::NoOutputFor(_)
+                | CommandError::Timeout(_)
+                | CommandError::KillAfterTimeoutFailed(_) => return FailureReason::Timeout,
+                CommandError::SandboxOOM => return FailureReason::OOM,
+                CommandError::SandboxImagePullFailed(_)
+                | CommandError::SandboxImageMissing(_)
+                | CommandError::SandboxContainerCreate(_)
+                | CommandError::WorkspaceNotMountedCorrectly
+                | CommandError::InvalidDockerInspectOutput(_) => return FailureReason::Docker,
+
+                CommandError::ExecutionFailed { .. } | CommandError::IO(_) | _ => {}
+            }
+        }
+
+        if let Some(reason) = cause.downcast_ref::<FailureReason>() {
             return reason.clone();
         } else if let Some(CommandError::IO(io)) = cause.downcast_ref() {
             match io.kind() {