From 53fe6976cfb39ee5780f066b4bfc11afdc5e18fa Mon Sep 17 00:00:00 2001 From: Jieyou Xu Date: Tue, 8 Jul 2025 14:51:13 +0800 Subject: [PATCH 1/2] [NFC] Reformat sentence to use "infinite-width" formatting That is consistent with rest of issue template. --- .github/ISSUE_TEMPLATE/major_change.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/major_change.md b/.github/ISSUE_TEMPLATE/major_change.md index ea432848..8ed10e62 100644 --- a/.github/ISSUE_TEMPLATE/major_change.md +++ b/.github/ISSUE_TEMPLATE/major_change.md @@ -17,9 +17,7 @@ assignees: '' # Mentors or Reviewers -*If you have a reviewer or mentor in mind for this work, mention them -here. You can put your own name here if you are planning to mentor the -work.* +*If you have a reviewer or mentor in mind for this work, mention them here. You can put your own name here if you are planning to mentor the work.* # Process From 6356c6f291c9064d245b5afecd776730d32c4f08 Mon Sep 17 00:00:00 2001 From: Jieyou Xu Date: Tue, 8 Jul 2025 14:58:12 +0800 Subject: [PATCH 2/2] Update MCP issue template --- .github/ISSUE_TEMPLATE/major_change.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/major_change.md b/.github/ISSUE_TEMPLATE/major_change.md index 8ed10e62..ee223602 100644 --- a/.github/ISSUE_TEMPLATE/major_change.md +++ b/.github/ISSUE_TEMPLATE/major_change.md @@ -24,10 +24,12 @@ assignees: '' The main points of the [Major Change Process][MCP] are as follows: * [x] File an issue describing the proposal. -* [ ] A compiler team member or contributor who is knowledgeable in the area can **second** by writing `@rustbot second`. - * Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a `-C flag`, then full team check-off is required. - * Compiler team members can initiate a check-off via `@rfcbot fcp merge` on either the MCP or the PR. -* [ ] Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered **approved**. +* [ ] A compiler team member who is knowledgeable in the area can **second** by writing `@rustbot second` or kickoff a team FCP with `@rfcbot fcp $RESOLUTION`. + * Refer to [Proposals, Approvals and Stabilization](https://forge.rust-lang.org/compiler/proposals-and-stabilization.html) docs for when a second is sufficient, or when a full team FCP is required. +* [ ] Once an MCP is seconded, the **Final Comment Period** begins. + * Final Comment Period lasts for 10 days after all outstanding concerns are solved. + * Outstanding concerns will block the Final Comment Period from finishing. Once all concerns are resolved, the 10 day countdown is restarted. + * If no concerns are raised after 10 days since the resolution of the last outstanding concern, the MCP is considered **approved**. You can read [more about Major Change Proposals on forge][MCP].