Skip to content

Commit ad7ee45

Browse files
committed
Add -fno-omit-frame-pointer with debug info
This'll help stack traces that don't use dwarf info or when dwarf info isn't otherwise available.
1 parent afe2fd6 commit ad7ee45

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

src/lib.rs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -196,10 +196,15 @@ enum ToolFamily {
196196

197197
impl ToolFamily {
198198
/// What the flag to request debug info for this family of tools look like
199-
fn debug_flag(&self) -> &'static str {
199+
fn add_debug_flags(&self, cmd: &mut Tool) {
200200
match *self {
201-
ToolFamily::Msvc { .. } => "/Z7",
202-
ToolFamily::Gnu | ToolFamily::Clang => "-g",
201+
ToolFamily::Msvc { .. } => {
202+
cmd.push_cc_arg("/Z7".into());
203+
}
204+
ToolFamily::Gnu | ToolFamily::Clang => {
205+
cmd.push_cc_arg("-g".into());
206+
cmd.push_cc_arg("-fno-omit-frame-pointer".into());
207+
}
203208
}
204209
}
205210

@@ -1128,8 +1133,8 @@ impl Build {
11281133
let nvcc_debug_flag = cmd.family.nvcc_debug_flag().into();
11291134
cmd.args.push(nvcc_debug_flag);
11301135
}
1131-
let debug_flag = cmd.family.debug_flag().into();
1132-
cmd.push_cc_arg(debug_flag);
1136+
let family = cmd.family;
1137+
family.add_debug_flags(&mut cmd);
11331138
}
11341139

11351140
// Target flags

0 commit comments

Comments
 (0)