Regression: Cargo nightly updates registry on every build with "path" crate

[bill-myers]

When one of the dependencies is local, specified using "path", Cargo updates the registry on every build.

I think this was supposed to be fixed, but is present with nightly Rust (but not stable).

[matklad]

@bill-myers could you give an example where this is happening? I don't seem able to reproduce locally

~/trash
λ rustc --version
rustc 1.26.0-nightly (e5277c145 2018-03-28)

~/trash
λ tree .
.
├── bar
│   ├── Cargo.toml
│   └── src
│       └── lib.rs
└── foo
    ├── Cargo.toml
    └── src
        └── main.rs

4 directories, 5 files

~/trash
λ cat foo/Cargo.toml
[package]
name = "foo"
version = "0.1.0"
authors = ["Aleksey Kladov <aleksey.kladov@gmail.com>"]

[dependencies]
rand = "*"

[dependencies.bar]
path = "../bar"


~/trash
λ cat bar/Cargo.toml
[package]
name = "bar"
version = "0.1.0"
authors = ["Aleksey Kladov <aleksey.kladov@gmail.com>"]

[dependencies]

~/trash
λ cd foo

~/trash/foo master*
λ cargo -v run # update registry because generating the lockfile
    Updating registry `https://github.com/rust-lang/crates.io-index`
   Compiling libc v0.2.40                                                       
   Compiling bar v0.1.0 (file:///home/matklad/trash/bar)
     Running `rustc --crate-name libc /home/matklad/.cargo/registry/src/github.com-1ecc6299db9ec823/libc-0.2.40/src/lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 --cfg 'feature="default"' --cfg 'feature="use_std"' -C metadata=aa82092d4ce0128b -C extra-filename=-aa82092d4ce0128b --out-dir /home/matklad/trash/foo/target/debug/deps -L dependency=/home/matklad/trash/foo/target/debug/deps --cap-lints allow`
     Running `rustc --crate-name bar /home/matklad/trash/bar/src/lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=ac66aa3e870053b3 -C extra-filename=-ac66aa3e870053b3 --out-dir /home/matklad/trash/foo/target/debug/deps -C incremental=/home/matklad/trash/foo/target/debug/incremental -L dependency=/home/matklad/trash/foo/target/debug/deps`
   Compiling rand v0.4.2
     Running `rustc --crate-name rand /home/matklad/.cargo/registry/src/github.com-1ecc6299db9ec823/rand-0.4.2/src/lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 --cfg 'feature="default"' --cfg 'feature="libc"' --cfg 'feature="std"' -C metadata=8f795c3a3470e796 -C extra-filename=-8f795c3a3470e796 --out-dir /home/matklad/trash/foo/target/debug/deps -L dependency=/home/matklad/trash/foo/target/debug/deps --extern libc=/home/matklad/trash/foo/target/debug/deps/liblibc-aa82092d4ce0128b.rlib --cap-lints allow`
   Compiling foo v0.1.0 (file:///home/matklad/trash/foo)
     Running `rustc --crate-name foo src/main.rs --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=e81d0fe435c73ad3 -C extra-filename=-e81d0fe435c73ad3 --out-dir /home/matklad/trash/foo/target/debug/deps -C incremental=/home/matklad/trash/foo/target/debug/incremental -L dependency=/home/matklad/trash/foo/target/debug/deps --extern rand=/home/matklad/trash/foo/target/debug/deps/librand-8f795c3a3470e796.rlib --extern bar=/home/matklad/trash/foo/target/debug/deps/libbar-ac66aa3e870053b3.rlib`
    Finished dev [unoptimized + debuginfo] target(s) in 2.24 secs
     Running `target/debug/foo`
Hello, world!

~/trash/foo master*
λ cargo -v run
       Fresh libc v0.2.40
       Fresh bar v0.1.0 (file:///home/matklad/trash/bar)
       Fresh rand v0.4.2
       Fresh foo v0.1.0 (file:///home/matklad/trash/foo)
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
     Running `target/debug/foo`
Hello, world!

~/trash/foo master*
λ touch src/main.rs

~/trash/foo master*
λ cargo -v run # no registry update, as expected
       Fresh libc v0.2.40
       Fresh bar v0.1.0 (file:///home/matklad/trash/bar)
       Fresh rand v0.4.2
   Compiling foo v0.1.0 (file:///home/matklad/trash/foo)
     Running `rustc --crate-name foo src/main.rs --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=e81d0fe435c73ad3 -C extra-filename=-e81d0fe435c73ad3 --out-dir /home/matklad/trash/foo/target/debug/deps -C incremental=/home/matklad/trash/foo/target/debug/incremental -L dependency=/home/matklad/trash/foo/target/debug/deps --extern rand=/home/matklad/trash/foo/target/debug/deps/librand-8f795c3a3470e796.rlib --extern bar=/home/matklad/trash/foo/target/debug/deps/libbar-ac66aa3e870053b3.rlib`
    Finished dev [unoptimized + debuginfo] target(s) in 0.28 secs
     Running `target/debug/foo`
Hello, world!

~/trash/foo master*
λ touch ../bar/src/lib.rs

~/trash/foo master*
λ cargo -v run
       Fresh libc v0.2.40
   Compiling bar v0.1.0 (file:///home/matklad/trash/bar)
       Fresh rand v0.4.2
     Running `rustc --crate-name bar /home/matklad/trash/bar/src/lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=ac66aa3e870053b3 -C extra-filename=-ac66aa3e870053b3 --out-dir /home/matklad/trash/foo/target/debug/deps -C incremental=/home/matklad/trash/foo/target/debug/incremental -L dependency=/home/matklad/trash/foo/target/debug/deps`
   Compiling foo v0.1.0 (file:///home/matklad/trash/foo)
     Running `rustc --crate-name foo src/main.rs --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=e81d0fe435c73ad3 -C extra-filename=-e81d0fe435c73ad3 --out-dir /home/matklad/trash/foo/target/debug/deps -C incremental=/home/matklad/trash/foo/target/debug/incremental -L dependency=/home/matklad/trash/foo/target/debug/deps --extern rand=/home/matklad/trash/foo/target/debug/deps/librand-8f795c3a3470e796.rlib --extern bar=/home/matklad/trash/foo/target/debug/deps/libbar-ac66aa3e870053b3.rlib`
    Finished dev [unoptimized + debuginfo] target(s) in 0.37 secs
     Running `target/debug/foo`
Hello, world!

[bill-myers]

The following commands reproduce it for me:

cargo new --bin bug
cd bug
git clone https://github.com/xfix/enum-map
(cd enum-map && git reset --hard 9d6c4e9ee3f9c28c3507dac7cc87d1b24b907ea0)
echo '"enum-map" = {path = "enum-map/enum-map"}' >> Cargo.toml

Running "cargo +nightly build" results in a registry update every time, while "cargo +stable build" (with Rust 1.25) doesn't.

It might be caused by something the "enum-map" crate is doing, since just creating a new library instead of cloning "enum-map" doesn't trigger it.

[matklad]

Yep, I've reproduced it, thanks a lot, @bill-myers !

[matklad]

Attempting to debug this, logs from nightly:

λ RUST_LOG=debug $c build --frozen
DEBUG 2018-03-29T19:05:33Z: cargo::core::workspace: find_root - trying /home/matklad/trash/Cargo.toml
DEBUG 2018-03-29T19:05:33Z: cargo::core::workspace: find_root - trying /home/matklad/Cargo.toml
DEBUG 2018-03-29T19:05:33Z: cargo::core::workspace: find_root - trying /home/Cargo.toml
DEBUG 2018-03-29T19:05:33Z: cargo::core::workspace: find_root - trying /Cargo.toml
DEBUG 2018-03-29T19:05:33Z: cargo::core::workspace: find_members - only me as a member
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: ignoring any lock pointing directly at synom v0.11.3
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: ignoring any lock pointing directly at unicode-xid v0.0.4
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: ignoring any lock pointing directly at quote v0.3.15
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: ignoring any lock pointing directly at array-macro v1.0.0
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: ignoring any lock pointing directly at syn v0.11.11
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: attempting to prefer bug v0.1.0 (file:///home/matklad/trash/bug)
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: attempting to prefer synom v0.11.3
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: attempting to prefer quote v0.3.15
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: attempting to prefer enum-map-derive v0.2.4 (file:///home/matklad/trash/bug/enum-map/enum-map-derive)
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: attempting to prefer enum-map v0.2.24 (file:///home/matklad/trash/bug/enum-map/enum-map)
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: attempting to prefer array-macro v1.0.0
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: attempting to prefer syn v0.11.11
DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: attempting to prefer unicode-xid v0.0.4
DEBUG 2018-03-29T19:05:33Z: cargo::core::registry: load/missing  file:///home/matklad/trash/bug
DEBUG 2018-03-29T19:05:33Z: cargo::sources::config: loading: file:///home/matklad/trash/bug
DEBUG 2018-03-29T19:05:33Z: cargo::core::resolver: initial activation: bug v0.1.0 (file:///home/matklad/trash/bug)
DEBUG 2018-03-29T19:05:33Z: cargo::core::registry: load/missing  file:///home/matklad/trash/bug/enum-map/enum-map
DEBUG 2018-03-29T19:05:33Z: cargo::sources::config: loading: file:///home/matklad/trash/bug/enum-map/enum-map
DEBUG 2018-03-29T19:05:33Z: cargo::core::registry: load/missing  registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:05:33Z: cargo::sources::config: loading: registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:05:33Z: cargo: exit_with_error; err=CliError { error: Some(ErrorMessage { msg: "attempting to make an HTTP request, but --frozen was specified" }

Unable to update registry `https://github.com/rust-lang/crates.io-index`

failed to load source for a dependency on `array-macro`), unknown: false, exit_code: 101 }
error: failed to load source for a dependency on `array-macro`

Caused by:
  Unable to update registry `https://github.com/rust-lang/crates.io-index`

Caused by:
  attempting to make an HTTP request, but --frozen was specified

and with stable

λ RUST_LOG=debug cargo build --frozen
DEBUG 2018-03-29T19:08:39Z: cargo::build: executing; cmd=cargo-build; args=["/home/matklad/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/cargo", "build", "--frozen"]
DEBUG 2018-03-29T19:08:39Z: cargo::core::workspace: find_root - trying /home/matklad/trash/Cargo.toml
DEBUG 2018-03-29T19:08:39Z: cargo::core::workspace: find_root - trying /home/matklad/Cargo.toml
DEBUG 2018-03-29T19:08:39Z: cargo::core::workspace: find_root - trying /home/Cargo.toml
DEBUG 2018-03-29T19:08:39Z: cargo::core::workspace: find_root - trying /Cargo.toml
DEBUG 2018-03-29T19:08:39Z: cargo::core::workspace: find_members - only me as a member
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/missing  file:///home/matklad/trash/bug
DEBUG 2018-03-29T19:08:39Z: cargo::sources::config: loading: file:///home/matklad/trash/bug
DEBUG 2018-03-29T19:08:39Z: cargo::core::resolver: initial activation: bug v0.1.0 (file:///home/matklad/trash/bug)
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/missing  file:///home/matklad/trash/bug/enum-map/enum-map
DEBUG 2018-03-29T19:08:39Z: cargo::sources::config: loading: file:///home/matklad/trash/bug/enum-map/enum-map
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/missing  registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::sources::config: loading: registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/missing  file:///home/matklad/trash/bug/enum-map/enum-map-derive
DEBUG 2018-03-29T19:08:39Z: cargo::sources::config: loading: file:///home/matklad/trash/bug/enum-map/enum-map-derive
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::resolver: checking if quote v0.3.15 is already activated
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::resolver: checking if unicode-xid v0.0.4 is already activated
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/locked   file:///home/matklad/trash/bug
DEBUG 2018-03-29T19:08:39Z: cargo::core::resolver: initial activation: bug v0.1.0 (file:///home/matklad/trash/bug)
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/precise  file:///home/matklad/trash/bug/enum-map/enum-map
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/precise  file:///home/matklad/trash/bug/enum-map/enum-map-derive
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::resolver: checking if quote v0.3.15 is already activated
DEBUG 2018-03-29T19:08:39Z: cargo::core::registry: load/match    registry `https://github.com/rust-lang/crates.io-index`
DEBUG 2018-03-29T19:08:39Z: cargo::core::resolver: checking if unicode-xid v0.0.4 is already activated
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::context: probe_target_info: crate_types={"bin", "proc-macro", "rlib"}
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::fingerprint: fingerprint at: /home/matklad/trash/bug/target/debug/.fingerprint/bug-3adf5cc65da58e02/bin-bug-3adf5cc65da58e02
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::context: Target filenames: [("/home/matklad/trash/bug/target/debug/deps/bug-3adf5cc65da58e02", Some("/home/matklad/trash/bug/target/debug/bug"), Normal)]
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::context: Target filenames: [("/home/matklad/trash/bug/target/debug/deps/libenum_map-7d87121bb0b1ab24.rlib", None, Linkable)]
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::fingerprint: fingerprint at: /home/matklad/trash/bug/target/debug/.fingerprint/enum-map-7d87121bb0b1ab24/lib-enum_map-7d87121bb0b1ab24
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::context: Target filenames: [("/home/matklad/trash/bug/target/debug/deps/libenum_map_derive-96f4d0d0d8453b8c.so", None, Linkable)]
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::context: Target filenames: [("/home/matklad/trash/bug/target/debug/deps/libarray_macro-be01a1eda32bd467.rlib", None, Linkable)]
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::fingerprint: fingerprint at: /home/matklad/trash/bug/target/debug/.fingerprint/enum-map-derive-96f4d0d0d8453b8c/lib-enum_map_derive-96f4d0d0d8453b8c
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::context: Target filenames: [("/home/matklad/trash/bug/target/debug/deps/libquote-304777cb3696ca3c.rlib", None, Linkable)]
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::context: Target filenames: [("/home/matklad/trash/bug/target/debug/deps/libsyn-33f4d1db6dd39836.rlib", None, Linkable)]
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::fingerprint: fingerprint at: /home/matklad/trash/bug/target/debug/.fingerprint/quote-304777cb3696ca3c/lib-quote-304777cb3696ca3c
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::fingerprint: fingerprint at: /home/matklad/trash/bug/target/debug/.fingerprint/syn-33f4d1db6dd39836/lib-syn-33f4d1db6dd39836
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::context: Target filenames: [("/home/matklad/trash/bug/target/debug/deps/libsynom-ac93423e9047e7c8.rlib", None, Linkable)]
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::context: Target filenames: [("/home/matklad/trash/bug/target/debug/deps/libunicode_xid-155fd845ac784c02.rlib", None, Linkable)]
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::fingerprint: fingerprint at: /home/matklad/trash/bug/target/debug/.fingerprint/synom-ac93423e9047e7c8/lib-synom-ac93423e9047e7c8
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::fingerprint: fingerprint at: /home/matklad/trash/bug/target/debug/.fingerprint/unicode-xid-155fd845ac784c02/lib-unicode_xid-155fd845ac784c02
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::fingerprint: fingerprint at: /home/matklad/trash/bug/target/debug/.fingerprint/array-macro-be01a1eda32bd467/lib-array_macro-be01a1eda32bd467
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: start: quote v0.3.15 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: end: quote v0.3.15 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: start: unicode-xid v0.0.4 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: end: unicode-xid v0.0.4 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: start: array-macro v1.0.0 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: end: array-macro v1.0.0 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: start: synom v0.11.3 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: end: synom v0.11.3 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: start: syn v0.11.11 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: end: syn v0.11.11 => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: start: enum-map-derive v0.2.4 (file:///home/matklad/trash/bug/enum-map/enum-map-derive) => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: end: enum-map-derive v0.2.4 (file:///home/matklad/trash/bug/enum-map/enum-map-derive) => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: start: enum-map v0.2.24 (file:///home/matklad/trash/bug/enum-map/enum-map) => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: end: enum-map v0.2.24 (file:///home/matklad/trash/bug/enum-map/enum-map) => Target(lib)/Profile(build) => Host
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: start: bug v0.1.0 (file:///home/matklad/trash/bug) => Target(bin: bug)/Profile(build) => Host
DEBUG 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc: linking /home/matklad/trash/bug/target/debug/deps/bug-3adf5cc65da58e02 to /home/matklad/trash/bug/target/debug/bug
 INFO 2018-03-29T19:08:39Z: cargo::ops::cargo_rustc::job_queue: end: bug v0.1.0 (file:///home/matklad/trash/bug) => Target(bin: bug)/Profile(build) => Host
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs

The interesting bit is

DEBUG 2018-03-29T19:05:33Z: cargo::ops::resolve: ignoring any lock pointing directly at synom v0.11.3

cc @Eh2406 :-)

[Eh2406]

That is from hear which was added in #5180 So cc @alexcrichton :-)

[matklad]

Ok, so the buggy logic is here I think:

cargo/src/cargo/ops/resolve.rs

Lines 457 to 466 in 4389f62

	// If we match *anything* in the dependency graph then we consider
	// ourselves A-OK and assume that we'll resolve to that. If,
	// however, nothing matches, then we poison the source of this
	// dependencies and the previous lock file.
	if resolve.iter().any(|id| dep.matches_ignoring_source(id)) {
	continue;
	}
	for id in resolve.iter().filter(|id| id.source_id() == source) {
	add_deps(resolve, id, &mut avoid_locking);
	}

Looks like if the dep is optional or dev, it is not present in resolve, and so we unlock all of its dependencies, which is wrong. This doesn't seem to trivial to fix.

[Eh2406]

This doesn't seem to trivial to fix.

I got lost in the double negatives. Do you see how to fix it?
Not that I understand this code in the farest place, it is more @alexcrichton expertise.

[matklad]

@Eh2406 I have no idea how to fix it, it would be awesome if you take a look :)

[alexcrichton]

I'm taking a look at this currently

[alexcrichton]

I've posted a fix in #5288