-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Open
Labels
C-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Command-cleanPerformanceGotta go fast!Gotta go fast!S-needs-designStatus: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.
Description
Problem
Spinned out from #10236 (comment)
#10236 introduces a progress bar for cargo clean
, which has a slight performance hit (0-10%). There are still some possibilities we can explore in this area to enhance its performance.
Proposed Solution
Some directions (and they might be entangled with each other)
- Parallelize the file removing process.
- The progress bar ticks too often, and might hurt the performance over a slow network connection.
- Fall back to non progress bar clean behavior when with
--quiet
flag on.
Notes
Unless this affects people a lot, I feel like it is not a high-priority task. Anyone interested in it should discuss with the cargo team first, though due to the limited review bandwidth, the team might not respond instantly.
FibreFoX, uncomfyhalomacro and best2come
Metadata
Metadata
Assignees
Labels
C-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Command-cleanPerformanceGotta go fast!Gotta go fast!S-needs-designStatus: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.