feat: Pass lints to tools

Author: epage

src/cargo/core/compiler/fingerprint/mod.rs

@@ -75,6 +75,7 @@
 //! [`Lto`] flags                              | ✓           | ✓
 //! config settings[^5]                        | ✓           |
 //! is_std                                     |             | ✓
+//! `[lints]` table                            | ✓           | ✓
 //!
 //! [^1]: Build script and bin dependencies are not included.
 //!
@@ -1414,6 +1415,7 @@ fn calculate_normal(cx: &mut Context<'_, '_>, unit: &Unit) -> CargoResult<Finger
         unit.mode,
         cx.bcx.extra_args_for(unit),
         cx.lto[unit],
+        unit.pkg.manifest().rustflags(),
     ));
     // Include metadata since it is exposed as environment variables.
     let m = unit.pkg.manifest().metadata();

src/cargo/core/compiler/mod.rs

@@ -762,6 +762,7 @@ fn rustdoc(cx: &mut Context<'_, '_>, unit: &Unit) -> CargoResult<Work> {
     add_error_format_and_color(cx, &mut rustdoc);
     add_allow_features(cx, &mut rustdoc);
 
+    rustdoc.args(unit.pkg.manifest().rustflags());
     if let Some(args) = cx.bcx.extra_args_for(unit) {
         rustdoc.args(args);
     }
@@ -1078,6 +1079,7 @@ fn build_base_args(
         cmd.arg("-C").arg(format!("debuginfo={}", debuginfo));
     }
 
+    cmd.args(unit.pkg.manifest().rustflags());
     if let Some(args) = cx.bcx.extra_args_for(unit) {
         cmd.args(args);
     }

tests/testsuite/lints.rs

@@ -1,6 +1,7 @@
 //! Tests for `[lints]`
 
 use cargo_test_support::project;
+use cargo_test_support::registry::Package;
 
 #[cargo_test]
 fn package_requires_option() {
@@ -203,3 +204,297 @@ Caused by:
         )
         .run();
 }
+
+#[cargo_test]
+fn package_lint_deny() {
+    let foo = project()
+        .file(
+            "Cargo.toml",
+            r#"
+                cargo-features = ["lints"]
+
+                [package]
+                name = "foo"
+                version = "0.0.1"
+                authors = []
+
+                [lints.rust]
+                "unsafe_code" = "deny"
+            "#,
+        )
+        .file(
+            "src/lib.rs",
+            "
+pub fn foo(num: i32) -> u32 {
+    unsafe { std::mem::transmute(num) }
+}
+",
+        )
+        .build();
+
+    foo.cargo("check")
+        .masquerade_as_nightly_cargo(&["lints"])
+        .with_status(101)
+        .with_stderr(
+            "\
+[..]
+error: usage of an `unsafe` block
+[..]
+[..]
+[..]
+[..]
+[..]
+[..]
+[..]
+error: could not compile `foo` (lib) due to previous error
+",
+        )
+        .run();
+}
+
+#[cargo_test]
+fn workspace_lint_deny() {
+    let foo = project()
+        .file(
+            "Cargo.toml",
+            r#"
+                cargo-features = ["lints"]
+
+                [package]
+                name = "foo"
+                version = "0.0.1"
+                authors = []
+
+                [lints]
+                workspace = true
+
+                [workspace.lints.rust]
+                "unsafe_code" = "deny"
+            "#,
+        )
+        .file(
+            "src/lib.rs",
+            "
+pub fn foo(num: i32) -> u32 {
+    unsafe { std::mem::transmute(num) }
+}
+",
+        )
+        .build();
+
+    foo.cargo("check")
+        .masquerade_as_nightly_cargo(&["lints"])
+        .with_status(101)
+        .with_stderr(
+            "\
+[..]
+error: usage of an `unsafe` block
+[..]
+[..]
+[..]
+[..]
+[..]
+[..]
+[..]
+error: could not compile `foo` (lib) due to previous error
+",
+        )
+        .run();
+}
+
+#[cargo_test]
+fn attribute_has_precedence() {
+    let foo = project()
+        .file(
+            "Cargo.toml",
+            r#"
+                cargo-features = ["lints"]
+
+                [package]
+                name = "foo"
+                version = "0.0.1"
+                authors = []
+
+                [lints.rust]
+                "unsafe_code" = "deny"
+            "#,
+        )
+        .file(
+            "src/lib.rs",
+            "
+#![allow(unsafe_code)]
+
+pub fn foo(num: i32) -> u32 {
+    unsafe { std::mem::transmute(num) }
+}
+",
+        )
+        .build();
+
+    foo.cargo("check")
+        .masquerade_as_nightly_cargo(&["lints"])
+        .with_status(0)
+        .run();
+}
+
+#[cargo_test]
+fn rustflags_has_precedence() {
+    let foo = project()
+        .file(
+            "Cargo.toml",
+            r#"
+                cargo-features = ["lints"]
+
+                [package]
+                name = "foo"
+                version = "0.0.1"
+                authors = []
+
+                [lints.rust]
+                "unsafe_code" = "deny"
+            "#,
+        )
+        .file(
+            "src/lib.rs",
+            "
+pub fn foo(num: i32) -> u32 {
+    unsafe { std::mem::transmute(num) }
+}
+",
+        )
+        .build();
+
+    foo.cargo("check")
+        .arg("-v")
+        .env("RUSTFLAGS", "-Aunsafe_code")
+        .masquerade_as_nightly_cargo(&["lints"])
+        .with_status(0)
+        .run();
+}
+
+#[cargo_test]
+fn without_priority() {
+    Package::new("reg-dep", "1.0.0").publish();
+
+    let foo = project()
+        .file(
+            "Cargo.toml",
+            r#"
+                cargo-features = ["lints"]
+
+                [package]
+                name = "foo"
+                version = "0.0.1"
+                edition = "2018"
+                authors = []
+
+                [dependencies]
+                reg-dep = "1.0.0"
+
+                [lints.rust]
+                "rust-2018-idioms" = "deny"
+                "unused-extern-crates" = "allow"
+            "#,
+        )
+        .file(
+            "src/lib.rs",
+            "
+extern crate reg_dep;
+
+pub fn foo() -> u32 {
+    2
+}
+",
+        )
+        .build();
+
+    foo.cargo("check")
+        .masquerade_as_nightly_cargo(&["lints"])
+        .with_status(101)
+        .with_stderr_contains(
+            "\
+error: unused extern crate
+",
+        )
+        .run();
+}
+
+#[cargo_test]
+fn with_priority() {
+    Package::new("reg-dep", "1.0.0").publish();
+
+    let foo = project()
+        .file(
+            "Cargo.toml",
+            r#"
+                cargo-features = ["lints"]
+
+                [package]
+                name = "foo"
+                version = "0.0.1"
+                edition = "2018"
+                authors = []
+
+                [dependencies]
+                reg-dep = "1.0.0"
+
+                [lints.rust]
+                "rust-2018-idioms" = { level = "deny", priority = -1 }
+                "unused-extern-crates" = "allow"
+            "#,
+        )
+        .file(
+            "src/lib.rs",
+            "
+extern crate reg_dep;
+
+pub fn foo() -> u32 {
+    2
+}
+",
+        )
+        .build();
+
+    foo.cargo("check")
+        .masquerade_as_nightly_cargo(&["lints"])
+        .with_status(0)
+        .run();
+}
+
+#[cargo_test]
+fn rustdoc_lint() {
+    let foo = project()
+        .file(
+            "Cargo.toml",
+            r#"
+                cargo-features = ["lints"]
+
+                [package]
+                name = "foo"
+                version = "0.0.1"
+                authors = []
+
+                [lints.rustdoc]
+                broken_intra_doc_links = "deny"
+            "#,
+        )
+        .file(
+            "src/lib.rs",
+            "
+/// [`bar`] doesn't exist
+pub fn foo() -> u32 {
+}
+",
+        )
+        .build();
+
+    foo.cargo("doc")
+        .masquerade_as_nightly_cargo(&["lints"])
+        .with_status(101)
+        .with_stderr_contains(
+            "\
+error: unresolved link to `bar`
+",
+        )
+        .run();
+}