Skip to content

Commit c4e150b

Browse files
committed
Fix review
1 parent c403187 commit c4e150b

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

src/cargo/util/toml/mod.rs

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1611,18 +1611,6 @@ impl DetailedTomlDependency {
16111611
}
16121612
}
16131613

1614-
if let Some(git) = self.git.clone() {
1615-
if let Ok(url) = git.into_url() {
1616-
if url.fragment().is_some() {
1617-
let msg = format!(
1618-
"hash in git url is ignored for dependency ({}). \
1619-
If you were trying to specify a specific git revision, use rev = \"revision\".",
1620-
name_in_toml);
1621-
cx.warnings.push(msg)
1622-
}
1623-
}
1624-
}
1625-
16261614
let new_source_id = match (
16271615
self.git.as_ref(),
16281616
self.path.as_ref(),
@@ -1673,6 +1661,17 @@ impl DetailedTomlDependency {
16731661
.or_else(|| self.rev.clone().map(GitReference::Rev))
16741662
.unwrap_or_else(|| GitReference::Branch("master".to_string()));
16751663
let loc = git.into_url()?;
1664+
1665+
if let Some(fragment) = loc.fragment() {
1666+
let msg = format!(
1667+
"URL fragment `#{}` in git URL is ignored for dependency ({}). \
1668+
If you were trying to specify a specific git revision, \
1669+
use `rev = \"{}\"` in the dependency declaration.",
1670+
fragment, name_in_toml, fragment
1671+
);
1672+
cx.warnings.push(msg)
1673+
}
1674+
16761675
SourceId::for_git(&loc, reference)?
16771676
}
16781677
(None, Some(path), _, _) => {

0 commit comments

Comments
 (0)