Skip to content

Commit b1642b5

Browse files
committed
fix: validate if name is empty
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
1 parent a7ff31f commit b1642b5

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/cargo/util_schemas/core/package_id_spec.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,9 @@ impl PackageIdSpec {
9898
Some(version) => Some(version.parse::<PartialVersion>()?),
9999
None => None,
100100
};
101+
if name.is_empty() {
102+
bail!("package ID specification must have a name: `{spec}`");
103+
}
101104
validate_package_name(name, "pkgid", "")?;
102105
Ok(PackageIdSpec {
103106
name: String::from(name),
@@ -597,6 +600,6 @@ mod tests {
597600
"sparse+https://github.com/rust-lang/cargo#0.52.0?branch=dev"
598601
)
599602
.is_err());
600-
assert!(PackageIdSpec::parse("@1.2.3").is_ok());
603+
assert!(PackageIdSpec::parse("@1.2.3").is_err());
601604
}
602605
}

0 commit comments

Comments
 (0)