feat(pkgid): suggestion for bad parsing

weihanglo · weihanglo · commit a22b3ac207bd · 2021-03-02T16:17:57.000+08:00
diff --git a/src/cargo/core/package_id_spec.rs b/src/cargo/core/package_id_spec.rs
@@ -87,8 +87,11 @@ impl PackageIdSpec {
     where
         I: IntoIterator<Item = PackageId>,
     {
-        let spec = PackageIdSpec::parse(spec)
-            .chain_err(|| anyhow::format_err!("invalid package ID specification: `{}`", spec))?;
+        let i: Vec<_> = i.into_iter().collect();
+        let spec = PackageIdSpec::parse(spec).chain_err(|| {
+            let suggestion = lev_distance::closest_msg(spec, i.iter(), |id| id.name().as_str());
+            anyhow::format_err!("invalid package ID specification: `{}`{}", spec, suggestion)
+        })?;
         spec.query(i)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -87,8 +87,11 @@ impl PackageIdSpec {`
`87`	`87`	`where`
`88`	`88`	`I: IntoIterator<Item = PackageId>,`
`89`	`89`	`{`
`90`		`- let spec = PackageIdSpec::parse(spec)`
`91`		- .chain_err(\|\| anyhow::format_err!("invalid package ID specification: `{}`", spec))?;
	`90`	`+ let i: Vec<_> = i.into_iter().collect();`
	`91`	`+ let spec = PackageIdSpec::parse(spec).chain_err(\|\| {`
	`92`	`+ let suggestion = lev_distance::closest_msg(spec, i.iter(), \|id\| id.name().as_str());`
	`93`	+ anyhow::format_err!("invalid package ID specification: `{}`{}", spec, suggestion)
	`94`	`+ })?;`
`92`	`95`	`spec.query(i)`
`93`	`96`	`}`
`94`	`97`