Skip to content

Commit 8d17219

Browse files
authored
chore(toml): disable toml's default features, unless necessary (#15598)
### What does this PR try to resolve? This reduces the build time of `cargo-util-schemas` by disabling the unused `display` and `parse` features of `toml` (which are enabled by default). This is useful as `cargo-util-schemas` is intended to be reused outside of Cargo. ### How should we test and review this PR? As I believe these features only *feature-gate* items on `toml` (they do not affect runtime behavior silently), the CI building successfully should be enough to make sure this does not break anything. ~If this does not build, I will try to tend to it today, otherwise feel free to push to this branch.~
2 parents 4aa9734 + 8362109 commit 8d17219

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ tar = { version = "0.4.43", default-features = false }
104104
tempfile = "3.20.0"
105105
thiserror = "2.0.11"
106106
time = { version = "0.3.37", features = ["parsing", "formatting", "serde"] }
107-
toml = "0.8.20"
107+
toml = { version = "0.8.20", default-features = false }
108108
toml_edit = { version = "0.22.23", features = ["serde"] }
109109
tracing = { version = "0.1.41", default-features = false, features = ["std"] } # be compatible with rustc_log: https://github.com/rust-lang/rust/blob/e51e98dde6a/compiler/rustc_log/Cargo.toml#L9
110110
tracing-chrome = "0.7.2"
@@ -210,7 +210,7 @@ tar.workspace = true
210210
tempfile.workspace = true
211211
thiserror.workspace = true
212212
time.workspace = true
213-
toml.workspace = true
213+
toml = { workspace = true, features = ["display", "parse"] }
214214
toml_edit.workspace = true
215215
tracing = { workspace = true, features = ["attributes"] }
216216
tracing-subscriber.workspace = true

benches/capture/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ publish = false
1010
cargo_metadata.workspace = true
1111
flate2.workspace = true
1212
tar.workspace = true
13-
toml.workspace = true
13+
toml = { workspace = true, features = ["display", "parse"] }
1414

1515
[lints]
1616
workspace = true

crates/cargo-test-support/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ serde_json.workspace = true
2727
snapbox.workspace = true
2828
tar.workspace = true
2929
time.workspace = true
30-
toml.workspace = true
30+
toml = { workspace = true, features = ["display"] }
3131
url.workspace = true
3232
walkdir.workspace = true
3333

0 commit comments

Comments
 (0)