Skip to content

Commit 88f858a

Browse files
committed
refactor(bump): Visual group related operations
1 parent 1566e4c commit 88f858a

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

crates/xtask-bump-check/src/xtask.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
114114
let base_commit = get_base_commit(gctx, args, &repo)?;
115115
let head_commit = get_head_commit(args, &repo)?;
116116
let referenced_commit = get_referenced_commit(&repo, &base_commit)?;
117-
let changed_members = changed(&ws, &repo, &base_commit, &head_commit)?;
118117
let status = |msg: &str| gctx.shell().status(STATUS, msg);
119118

120119
let crates_not_check_against_channels = [
@@ -135,9 +134,8 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
135134
status(&format!("head commit `{}`", head_commit.id()))?;
136135

137136
let mut needs_bump = Vec::new();
138-
137+
let changed_members = changed(&ws, &repo, &base_commit, &head_commit)?;
139138
check_crates_io(&ws, &changed_members, &mut needs_bump)?;
140-
141139
if let Some(referenced_commit) = referenced_commit.as_ref() {
142140
status(&format!("compare against `{}`", referenced_commit.id()))?;
143141
for referenced_member in checkout_ws(&ws, &repo, referenced_commit)?.members() {
@@ -157,7 +155,6 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
157155
}
158156
}
159157
}
160-
161158
if !needs_bump.is_empty() {
162159
needs_bump.sort();
163160
needs_bump.dedup();

0 commit comments

Comments
 (0)