fix(lints): Put lints after profile.rustflags

This does involve a subtle change to `profile.rustflags` precedence but
its nightly and most likely people won't notice it?  The benefit is its
in a location more like the rest of the rustflags.

Author: epage

src/cargo/core/compiler/mod.rs

@@ -1041,10 +1041,6 @@ fn build_base_args(
         cmd.arg("-C").arg(&format!("opt-level={}", opt_level));
     }
 
-    if !rustflags.is_empty() {
-        cmd.args(&rustflags);
-    }
-
     if *panic != PanicStrategy::Unwind {
         cmd.arg("-C").arg(format!("panic={}", panic));
     }
@@ -1080,6 +1076,9 @@ fn build_base_args(
     }
 
     cmd.args(unit.pkg.manifest().rustflags());
+    if !rustflags.is_empty() {
+        cmd.args(&rustflags);
+    }
     if let Some(args) = cx.bcx.extra_args_for(unit) {
         cmd.args(args);
     }

tests/testsuite/lints.rs

@@ -435,7 +435,7 @@ pub fn foo(num: i32) -> u32 {
 }
 
 #[cargo_test]
-fn profile_rustflags_doesnt_have_precedence() {
+fn profile_rustflags_has_precedence() {
     let foo = project()
         .file(
             "Cargo.toml",
@@ -447,10 +447,10 @@ fn profile_rustflags_doesnt_have_precedence() {
                 version = "0.0.1"
 
                 [lints.rust]
-                "unsafe_code" = "allow"
+                "unsafe_code" = "deny"
 
                 [profile.dev]
-                rustflags = ["-D", "unsafe_code"]
+                rustflags = ["-A", "unsafe_code"]
             "#,
         )
         .file(
@@ -466,7 +466,6 @@ pub fn foo(num: i32) -> u32 {
     foo.cargo("check")
         .arg("-v")
         .masquerade_as_nightly_cargo(&["lints", "profile-rustflags"])
-        .with_status(0)
         .run();
 }